Adds iterator_diff_ and iterator_intersect_ functions#2
Draft
Adds iterator_diff_ and iterator_intersect_ functions#2
iterator_diff_ and iterator_intersect_ functions#2Conversation
iterator_diff_ and iterator_intersect_ functionsiterator_diff_ and iterator_intersect_ functions
iterator_diff_ and iterator_intersect_ functionsiterator_diff_ and iterator_intersect_ functions
- Cleaned up exception tests with `toThrow` - Added benchmark tests for iterator_diff and iterator_map
Owner
Author
|
Added 2 benchmark tests. It proves that There might be a way to speed things up a bit, but that would require an array hash-map, which will negate the memory benefits. So the only added value is you: can directly reference an iterator without the use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike stated in the
READMEit can be possible to implement_diffand_intersectfunctions by repeatedly looping of the provided iterators. Because this is probably not the most performant check, for now this PR is mostly an experiment. It remains to be seen if it will be released.This PR tries to implement the following functions:
iterator_diffiterator_diff_associterator_diff_keyiterator_diff_uassociterator_diff_ukeyiterator_udiffiterator_udiff_associterator_udiff_uassociterator_intersectiterator_intersect_associterator_intersect_keyiterator_intersect_uassociterator_intersect_ukeyiterator_uintersectiterator_uintersect_associterator_uintersect_uassocTodo: