Skip to content

Declare return types for font collection iterator methods #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bsweeney wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Declare return types for font collection iterator methods #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/FontLib/TrueType/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class Collection extends BinaryStream implements Iterator, Countable {
protected $version;
protected $numFonts;

function parse() {
function parse() : void {
if (isset($this->numFonts)) {
return;
}
Expand All @@ -51,7 +51,7 @@ function parse() {
* @throws OutOfBoundsException
* @return File
*/
function getFont($fontId) {
function getFont($fontId) : File {
$this->parse();

if (!isset($this->collectionOffsets[$fontId])) {
Expand All @@ -69,29 +69,29 @@ function getFont($fontId) {
return $this->collection[$fontId] = $font;
}

function current() {
function current() : File {
return $this->getFont($this->position);
}

function key() {
function key() : int {
return $this->position;
}

function next() {
return ++$this->position;
function next() : void {
++$this->position;
}

function rewind() {
function rewind() : void {
$this->position = 0;
}

function valid() {
function valid() : bool {
$this->parse();

return isset($this->collectionOffsets[$this->position]);
}

function count() {
function count(): int {
$this->parse();

return $this->numFonts;
Expand Down