Fix NuGetConfigUpdater removing all credentials for preview builds #7036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an internal preview version was applied, the UpdatePackageSourceCredentials method removed the entire packageSourceCredentials element, wiping credentials for all versions. Now only the current version's entry is removed, preserving credentials for other versions that need authenticated feed access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug where applying an internal preview .NET version via
update-dependencieswould remove all authenticated NuGet feed credentialsfrom the test NuGet.config, not just the current version's entry.
Changes
UpdatePackageSourceCredentialsto only remove the current version'scredential entry from
<packageSourceCredentials>instead of removing theentire element
Context
When an internal build of a public preview .NET version was applied (e.g. .NET
11 Preview), the
elsebranch ofUpdatePackageSourceCredentialscalledpkgSourceCreds?.Remove(), which wiped the entire<packageSourceCredentials>element — including credentials for other non-preview versions (e.g. .NET 9)
that still need authenticated feed access.