Apply source generators to primary project only#1236
Open
kzrnm wants to merge 2 commits intodotnet:mainfrom
Open
Apply source generators to primary project only#1236kzrnm wants to merge 2 commits intodotnet:mainfrom
kzrnm wants to merge 2 commits intodotnet:mainfrom
Conversation
kzrnm
force-pushed
the
NoGenerateInAdditionalProjects
branch
from
d3b37f8 to
631988a
Compare
kzrnm
force-pushed
the
NoGenerateInAdditionalProjects
branch
from
631988a to
32bde08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
VerifyDiagnosticsAsync, analyzers and generators are also applied toAdditionalProjects.I don’t think this produces the intended test behavior.
More importantly, it’s inconsistent with
VerifySourceGeneratorAsync, where generators are applied only to the primary project.https://github.com/dotnet/roslyn-sdk/blob/f500e81ba5596809e711a3022bf8e80a00c8371b/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest%601.cs#L273C66-L283