Allow PublishReadyToRunEmitSymbols to be overridden #121406
Conversation
|
Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the PublishReadyToRunEmitSymbols property initialization to respect user-provided values. Previously, the property was unconditionally set to false for Apple platforms (iOS, tvOS, macOS Catalyst), which prevented users from overriding this behavior.
Key Changes:
- Modified the condition for
PublishReadyToRunEmitSymbolsto only set it tofalsewhen the property hasn't been explicitly set by the user
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| <PublishReadyToRunUseRuntimePackOptimizationData Condition="'$(PublishReadyToRunUseRuntimePackOptimizationData)' == ''">true</PublishReadyToRunUseRuntimePackOptimizationData> | ||
| <PublishReadyToRunPerfmapFormatVersion Condition="'$(PublishReadyToRunPerfmapFormatVersion)' == ''">1</PublishReadyToRunPerfmapFormatVersion> | ||
| <PublishReadyToRunEmitSymbols Condition="'$(TargetOS)' == 'ios' or '$(TargetOS)' == 'iossimulator' or '$(TargetOS)' == 'tvos' or '$(TargetOS)' == 'tvossimulator' or '$(TargetOS)' == 'maccatalyst'">false</PublishReadyToRunEmitSymbols> | ||
| <PublishReadyToRunEmitSymbols Condition="'$(PublishReadyToRunEmitSymbols)' == '' and ('$(TargetOS)' == 'ios' or '$(TargetOS)' == 'iossimulator' or '$(TargetOS)' == 'tvos' or '$(TargetOS)' == 'tvossimulator' or '$(TargetOS)' == 'maccatalyst')">false</PublishReadyToRunEmitSymbols> |
There was a problem hiding this comment.
we should also use TargetPlatformIdentifier here instead of TargetOS so that this file goes back to being 100% the same as the sdk copy.
we can set PublishReadyToRunEmitSymbols in runtime's Directory.Build.props or somewhere else based on the TargetOS then
|
I think arcade overrides PublishReadyToRunEmitSymbols in https://github.com/dotnet/arcade/blob/7d717a49d570577936361c14de38bf61271aa274/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L10 iOS build is failing with the System.NotImplementedException: iOS |
|
We can change arcade to not forcibly override it. |
|
Arcade PR here: dotnet/arcade#16281 |
4 participants
Description
This PR updates PublishReadyToRunEmitSymbols to allow it to be overridden. It aligns the behavior with the SDK mirror.