33 refactor corpus #36
Open
dpom wants to merge 6 commits into
Open
Conversation
…33-refactor-corpus
📝 WalkthroughWalkthroughRefactors the project to use directory-based corpus processing, replaces interactive Matplotlib display with an Emacs-driven image pipeline, adds ~120+ EDN corpus data files, updates reference-building to walk corpus directories, and adjusts specs, utilities, and translator modules accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant CLI
participant Corpus as "steno.corpus"
participant Translator as "translators"
participant Utils as "steno.utils / FS"
participant Emacs as "emacsclient"
CLI->>Corpus: extract glyphs / walk corpus
Corpus->>Corpus: convert glyph -> wsign / emit per-lsign EDN (save via Utils)
CLI->>Translator: request build-references / translate (pointed to corpus-dir)
Translator->>Utils: load EDN files from corpus-dir
Translator->>CLI: stream translated text output
CLI->>Emacs: request image display (PNG bytes)
Emacs-->>CLI: render image
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (4)
resources/corpus/o/yoga1-10-08-6.edn (1)
1-1: Consider adding a trailing newline.The file is missing a trailing newline, which is a POSIX text file convention and often flagged by linters/formatters.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@resources/corpus/o/yoga1-10-08-6.edn` at line 1, This EDN file ends without a trailing newline; open the record that starts with the map token "{:fileimage \"tmp/yoga1.png\" ...}" (the top-level EDN map) and append a single newline character at the end of the file so the file ends with a trailing newline (POSIX text file convention).src/steno/corpus.lpy (1)
71-80: Minor documentation typos.The docstring has a couple of typos: "side-efect" should be "side-effect" and "director" should be "directory".
✏️ Proposed fix
(defn walk-corpus - "Traverse the directories in CORPUS-DIR and apply the PROCESS-FN function to FILTERed ones. - The function is side-efect free and accepts the director as an argument. + "Traverse the directories in CORPUS-DIR and apply the PROCESS-FN function to FILTERed ones. + The function is side-effect free and accepts the directory as an argument. Returns a lazy collection."🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/steno/corpus.lpy` around lines 71 - 80, Update the docstring of the function walk-corpus to correct the typos: change "side-efect" to "side-effect" and "director" to "directory", keeping the rest of the description intact (mentioning CORPUS-DIR, PROCESS-FN, FILTERed, and that it returns a lazy collection).src/steno/translators/freq.lpy (1)
134-164: Consider updating or removing stale comment block.The comment block references the old API (
tra/load-edn, passing corpus object directly totra/build-references), which no longer matches the refactored implementation that usesutl/load-ednand directory-based corpus walking.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/steno/translators/freq.lpy` around lines 134 - 164, The large commented example in src/steno/translators/freq.lpy is stale: it shows the old API (tra/load-edn and passing a corpus object into tra/build-references) but the codebase now uses utl/load-edn and a directory-based corpus walker; update or remove this block. Locate the comment block containing calls like tra/load-edn, tra/build-references, tra/translate and either rewrite the examples to use utl/load-edn and the current directory-walking helpers and the new build-references signature, or delete the entire example comment to avoid confusion.src/steno/translators/diff.lpy (1)
171-214: Consider updating or removing stale comment block.The comment block references
tra/load-ednandtra/save-ednwhich have been removed fromtranslator.lpy. These utilities are now insteno.utils.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/steno/translators/diff.lpy` around lines 171 - 214, The large commented example in diff.lpy is stale because it calls tra/load-edn and tra/save-edn which were removed from translator.lpy; either delete the entire comment block or update it to use the new utilities (steno.utils/load-edn and steno.utils/save-edn) and any new API names, and adjust the example to call the current translate helpers (e.g., translate-numseq, tra/translate) as needed; locate the block by the long (comment ... ) section and replace or remove references to tra/load-edn and tra/save-edn (and any other changed symbols) so the example reflects the current steno.utils APIs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/steno/core.lpy`:
- Around line 64-79: The routines that write to user-specified output files
(notably the action-translate flow where you open outfile with (bio/writer
outfile) and the similar action-make-references flow) assume parent directories
exist; update both to ensure the destination directory is created before opening
the writer: compute the parent directory of outfile, create it (recursively) if
missing, then proceed to create the writer and write output. Locate the places
referencing outfile and the writer creation (the block with (with-open [of
(bio/writer outfile)] ...] and the analogous block in action-make-references)
and add a directory-creation step before opening the writer so writes cannot
fail on fresh paths.
- Around line 95-101: The binding for text uses (get (tra/translate-lsign ctx
translators lsign) :text "@") but tra/translate-lsign always includes the :text
key (sometimes as nil), so the default "@" is never used; update the text
extraction to coalesce nil to "@" (e.g. retrieve the translation map into a
local like translated and set text to (or (:text translated) "@") or use an
explicit nil check) so lsign-dir = (bio/path outdir text) always receives "@"
for untranslated glyphs; adjust references in this let block (lsign,
translated/translation map, text, lsign-dir) accordingly.
In `@src/steno/corpus.lpy`:
- Around line 13-25: Rename the function extract-lsign-from-wsing! to
extract-lsign-from-wsign! to fix the typo: update the defn name and any
references/call sites that invoke extract-lsign-from-wsing! to the new name
extract-lsign-from-wsign! (ensure parameter list [imagefile outdir row column
wsign] and internal usage of wsign/ws remain unchanged); search the repo for
extract-lsign-from-wsing! and replace all occurrences so callers (and any public
API/exports) use extract-lsign-from-wsign! consistently.
In `@src/steno/show.lpy`:
- Around line 17-25: Temporary PNG files created by tf/NamedTemporaryFile with
:delete false (tmp-path) are never removed after calling sp/run to invoke
emacsclient, leaking one file per show-* call; fix by ensuring tmp-path is
unlinked in a finally/ensure block after the (.close tmp) and sp/run
["emacsclient" ...] call so the file is removed regardless of success or
exceptions—use the project’s file-unlink utility (or fs/remove/io-file delete)
to delete tmp-path and catch/log any unlink errors so cleanup never silently
fails.
- Around line 75-77: The code calls (plt/subplots num-rows num-cols ...) even
when glyphs is empty or all rows empty; add a guard before creating the subplot
grid to handle the "no glyphs to show" case: compute num-rows and num-cols as
currently done, then if (or (zero? num-rows) (zero? num-cols)) return/exit early
(no-op or a simple message) instead of invoking plt/subplots; update the logic
around the local bindings that define glyphs, num-rows, num-cols and the call to
plt/subplots so functions like plt/subplots are only called when both num-rows
and num-cols are > 0.
---
Nitpick comments:
In `@resources/corpus/o/yoga1-10-08-6.edn`:
- Line 1: This EDN file ends without a trailing newline; open the record that
starts with the map token "{:fileimage \"tmp/yoga1.png\" ...}" (the top-level
EDN map) and append a single newline character at the end of the file so the
file ends with a trailing newline (POSIX text file convention).
In `@src/steno/corpus.lpy`:
- Around line 71-80: Update the docstring of the function walk-corpus to correct
the typos: change "side-efect" to "side-effect" and "director" to "directory",
keeping the rest of the description intact (mentioning CORPUS-DIR, PROCESS-FN,
FILTERed, and that it returns a lazy collection).
In `@src/steno/translators/diff.lpy`:
- Around line 171-214: The large commented example in diff.lpy is stale because
it calls tra/load-edn and tra/save-edn which were removed from translator.lpy;
either delete the entire comment block or update it to use the new utilities
(steno.utils/load-edn and steno.utils/save-edn) and any new API names, and
adjust the example to call the current translate helpers (e.g.,
translate-numseq, tra/translate) as needed; locate the block by the long
(comment ... ) section and replace or remove references to tra/load-edn and
tra/save-edn (and any other changed symbols) so the example reflects the current
steno.utils APIs.
In `@src/steno/translators/freq.lpy`:
- Around line 134-164: The large commented example in
src/steno/translators/freq.lpy is stale: it shows the old API (tra/load-edn and
passing a corpus object into tra/build-references) but the codebase now uses
utl/load-edn and a directory-based corpus walker; update or remove this block.
Locate the comment block containing calls like tra/load-edn,
tra/build-references, tra/translate and either rewrite the examples to use
utl/load-edn and the current directory-walking helpers and the new
build-references signature, or delete the entire example comment to avoid
confusion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 97e3f32a-5786-484c-abc0-2e4c59a66b2f
⛔ Files ignored due to path filters (2)
Notebook.orgis excluded by!Notebook.org,!*.orgREADME.orgis excluded by!*.org
📒 Files selected for processing (142)
.gitignoreresources/corpus/a/template-01-04-1.ednresources/corpus/a/template-02-00-0.ednresources/corpus/a/template-02-01-1.ednresources/corpus/a/template-03-00-1.ednresources/corpus/a/template-04-03-1.ednresources/corpus/a/template-05-01-0.ednresources/corpus/a/yoga1-00-14-4.ednresources/corpus/a/yoga1-00-15-1.ednresources/corpus/a/yoga1-03-03-1.ednresources/corpus/a/yoga1-04-01-0.ednresources/corpus/a/yoga1-09-27-1.ednresources/corpus/a/yoga1-09-29-3.ednresources/corpus/a/yoga1-13-02-0.ednresources/corpus/a/yoga1-15-00-6.ednresources/corpus/a/yoga1_12-16-06-0.ednresources/corpus/b/yoga1-04-01-1.ednresources/corpus/b/yoga1-17-08-1.ednresources/corpus/c/template-00-02-0.ednresources/corpus/c/template-04-04-3.ednresources/corpus/c/yoga1-09-12-0.ednresources/corpus/c/yoga1-09-18-6.ednresources/corpus/c/yoga1-13-02-2.ednresources/corpus/c/yoga1-15-01-0.ednresources/corpus/c/yoga1-17-05-1.ednresources/corpus/c/yoga1-19-00-3.ednresources/corpus/c/yoga1_12-03-02-1.ednresources/corpus/c/yoga1_12-10-07-1.ednresources/corpus/c/yoga1_12-10-36-0.ednresources/corpus/c/yoga1_12-11-02-0.ednresources/corpus/c/yoga1_12-16-00-0.ednresources/corpus/d/yoga1-03-01-5.ednresources/corpus/d/yoga1-03-01-8.ednresources/corpus/d/yoga1-04-01-2.ednresources/corpus/d/yoga1-05-02-7.ednresources/corpus/d/yoga1-09-27-0.ednresources/corpus/d/yoga1-16-01-1.ednresources/corpus/d/yoga1-16-08-2.ednresources/corpus/d/yoga1-17-05-4.ednresources/corpus/d/yoga1-17-09-6.ednresources/corpus/d/yoga1-17-10-0.ednresources/corpus/d/yoga1_12-01-03-1.ednresources/corpus/e/template-01-06-0.ednresources/corpus/f/template-00-03-0.ednresources/corpus/g/yoga1-11-02-2.ednresources/corpus/g/yoga1_12-03-07-0.ednresources/corpus/g/yoga1_12-07-00-2.ednresources/corpus/i/template-01-07-0.ednresources/corpus/j/template-01-02-0.ednresources/corpus/j/template-04-00-0.ednresources/corpus/j/template-04-04-0.ednresources/corpus/l/yoga1-16-08-3.ednresources/corpus/m/template-01-00-0.ednresources/corpus/m/template-04-01-1.ednresources/corpus/m/template-04-02-0.ednresources/corpus/n/template-01-01-0.ednresources/corpus/o/template-01-05-1.ednresources/corpus/o/template-03-02-1.ednresources/corpus/o/template-04-01-0.ednresources/corpus/o/template-04-02-1.ednresources/corpus/o/template-04-04-2.ednresources/corpus/o/yoga1-00-03-2.ednresources/corpus/o/yoga1-05-02-0.ednresources/corpus/o/yoga1-09-17-3.ednresources/corpus/o/yoga1-09-35-1.ednresources/corpus/o/yoga1-09-38-0.ednresources/corpus/o/yoga1-10-06-2.ednresources/corpus/o/yoga1-10-07-7.ednresources/corpus/o/yoga1-10-08-6.ednresources/corpus/o/yoga1-10-09-0.ednresources/corpus/o/yoga1-11-01-1.ednresources/corpus/o/yoga1-13-02-3.ednresources/corpus/o/yoga1-15-05-0.ednresources/corpus/o/yoga1-16-01-0.ednresources/corpus/o/yoga1-16-08-1.ednresources/corpus/o/yoga1-16-12-0.ednresources/corpus/o/yoga1-17-08-0.ednresources/corpus/o/yoga1-17-08-9.ednresources/corpus/o/yoga1-18-02-1.ednresources/corpus/o/yoga1-18-04-0.ednresources/corpus/o/yoga1-21-30-1.ednresources/corpus/o/yoga1-21-61-1.ednresources/corpus/o/yoga1_12-03-00-9.ednresources/corpus/o/yoga1_12-03-04-1.ednresources/corpus/o/yoga1_12-04-01-0.ednresources/corpus/o/yoga1_12-04-01-3.ednresources/corpus/o/yoga1_12-04-03-0.ednresources/corpus/o/yoga1_12-04-05-1.ednresources/corpus/o/yoga1_12-06-11-0.ednresources/corpus/o/yoga1_12-07-00-3.ednresources/corpus/o/yoga1_12-09-01-3.ednresources/corpus/o/yoga1_12-10-02-1.ednresources/corpus/o/yoga1_12-10-32-1.ednresources/corpus/o/yoga1_12-11-03-0.ednresources/corpus/o/yoga1_12-11-13-0.ednresources/corpus/o/yoga1_12-12-06-0.ednresources/corpus/o/yoga1_12-16-03-1.ednresources/corpus/o/yoga1_12-18-03-0.ednresources/corpus/o/yoga1_12-21-04-0.ednresources/corpus/o/yoga1_12-23-01-0.ednresources/corpus/o/yoga1_12-23-02-0.ednresources/corpus/o/yoga1_12-23-03-0.ednresources/corpus/p/template-00-00-0.ednresources/corpus/p/template-02-00-1.ednresources/corpus/p/template-03-00-0.ednresources/corpus/p/template-03-01-0.ednresources/corpus/p/template-03-02-0.ednresources/corpus/r/template-03-02-3.ednresources/corpus/r/yoga1-00-01-0.ednresources/corpus/r/yoga1-17-06-0.ednresources/corpus/r/yoga1-18-02-0.ednresources/corpus/r/yoga1-21-02-1.ednresources/corpus/r/yoga1_12-02-08-1.ednresources/corpus/r/yoga1_12-05-01-0.ednresources/corpus/r/yoga1_12-05-07-3.ednresources/corpus/r/yoga1_12-06-00-0.ednresources/corpus/r/yoga1_12-23-02-3.ednresources/corpus/s/template-01-03-0.ednresources/corpus/s/template-04-02-2.ednresources/corpus/s/template-04-03-0.ednresources/corpus/t/template-00-01-0.ednresources/corpus/t/template-02-01-0.ednresources/corpus/t/template-03-00-2.ednresources/corpus/t/template-03-01-1.ednresources/corpus/t/template-04-03-3.ednresources/corpus/t/yoga1-17-08-2.ednresources/corpus/ţ/template-01-08-0.ednresources/diff-references.ednresources/freq-references.ednsrc/steno/converter.lpysrc/steno/core.lpysrc/steno/corpus.cljsrc/steno/corpus.lpysrc/steno/extractor.lpysrc/steno/imageprocessor.lpysrc/steno/show.lpysrc/steno/spec.lpysrc/steno/translator.lpysrc/steno/translators/diff.lpysrc/steno/translators/freq.lpysrc/steno/utils.lpytemplate.txt
💤 Files with no reviewable changes (1)
- src/steno/corpus.clj
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
src/steno/core.lpy (2)
121-123:⚠️ Potential issue | 🟠 MajorEnsure the references output directory exists.
utl/save-ednwrites directly tooutfile, so a new-odirectory still fails here unless it is created first.🛠️ Proposed fix
(let [references (tra/build-references tr config corpus-dir) outfile (bio/path outdir (str tr "-references.edn"))] + (.mkdir (Path. outdir) ** :parents true :exist_ok true) (utl/save-edn outfile references) (.info logger "saved in %s" outfile)))🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/steno/core.lpy` around lines 121 - 123, The code calls tra/build-references and then utl/save-edn with outfile but does not ensure the target directory exists; before calling utl/save-edn, create the output directory (outdir or the parent directory of outfile) if missing so writing won't fail. Locate the block using references, outfile, bio/path and add a directory-creation step (mkdir -p / ensure-parent-dirs) for outdir or outfile's parent prior to calling utl/save-edn.
65-79:⚠️ Potential issue | 🟠 MajorCreate the parent directory before opening
outfile.A fresh
-opath still fails here becausebio/writeris opened before the parent directory exists.action-make-corpusalready handles this case.🛠️ Proposed fix
(let [infile (get config "input") outfile (get config "output") translators (get config "translators") logger (:logger config)] (.info logger "Translate %s using %s" infile translators) + (when-let [parent (.parent (Path. outfile))] + (.mkdir parent ** :parents true :exist_ok true)) (with-open [of (bio/writer outfile)]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/steno/core.lpy` around lines 65 - 79, The code opens bio/writer on outfile before ensuring its parent directory exists, causing failures for new -o paths; before the with-open that invokes (bio/writer outfile) ensure the parent directory of outfile is created (use the same approach as action-make-corpus: compute the parent dir from outfile and create it if missing, e.g. mkdirs or an equivalent I/O util) so that bio/writer can open the file successfully.
🧹 Nitpick comments (1)
src/steno/core.lpy (1)
70-72: Move per-glyph translation logs to DEBUG.This runs once per glyph, so keeping it at INFO will flood normal CLI output and slow larger images.
🔇 Small tweak
- (.info logger "text: %s" text) + (.debug logger "text: %s" text)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/steno/core.lpy` around lines 70 - 72, The per-glyph log currently emitted at info level inside the anonymous function (f! / fn [row _column {:keys [wsign]}]) that calls tra/translate-wsign should be lowered to debug to avoid flooding output; replace the logger .info call ("text: %s" text) with a debug-level call (e.g., logger.debug) so translate-wsign's per-glyph messages only appear when debugging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/steno/core.lpy`:
- Around line 135-150: The renormalization currently lets exceptions from
utl/load-edn or utl/save-edn abort the whole batch; update renormalize-lsigns!
to catch exceptions per file and continue: wrap the load → cnv/normalize2-lsign
→ save pipeline in a try/catch (or try) that on error logs the file path and the
exception and skips to the next file. To access logging, either add a logger
parameter to renormalize-lsigns! (and pass the :logger from
action-renormalize-corpus) or perform the try/catch inside
action-renormalize-corpus when invoking the per-file work; in either case ensure
errors from utl/load-edn and utl/save-edn are caught, logged, and do not rethrow
so the corpus walk completes.
---
Duplicate comments:
In `@src/steno/core.lpy`:
- Around line 121-123: The code calls tra/build-references and then utl/save-edn
with outfile but does not ensure the target directory exists; before calling
utl/save-edn, create the output directory (outdir or the parent directory of
outfile) if missing so writing won't fail. Locate the block using references,
outfile, bio/path and add a directory-creation step (mkdir -p /
ensure-parent-dirs) for outdir or outfile's parent prior to calling
utl/save-edn.
- Around line 65-79: The code opens bio/writer on outfile before ensuring its
parent directory exists, causing failures for new -o paths; before the with-open
that invokes (bio/writer outfile) ensure the parent directory of outfile is
created (use the same approach as action-make-corpus: compute the parent dir
from outfile and create it if missing, e.g. mkdirs or an equivalent I/O util) so
that bio/writer can open the file successfully.
---
Nitpick comments:
In `@src/steno/core.lpy`:
- Around line 70-72: The per-glyph log currently emitted at info level inside
the anonymous function (f! / fn [row _column {:keys [wsign]}]) that calls
tra/translate-wsign should be lowered to debug to avoid flooding output; replace
the logger .info call ("text: %s" text) with a debug-level call (e.g.,
logger.debug) so translate-wsign's per-glyph messages only appear when
debugging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e732cedd-999b-471e-bda7-02a2179878d7
⛔ Files ignored due to path filters (1)
Notebook.orgis excluded by!Notebook.org,!*.org
📒 Files selected for processing (65)
resources/corpus/a/template-01-04-1.ednresources/corpus/a/template-02-00-0.ednresources/corpus/a/template-02-01-1.ednresources/corpus/a/template-03-00-1.ednresources/corpus/a/template-04-03-1.ednresources/corpus/a/template-05-01-0.ednresources/corpus/c/template-00-02-0.ednresources/corpus/c/template-04-04-3.ednresources/corpus/c/yoga1_12-03-06-1.ednresources/corpus/c/yoga1_12-10-02-2.ednresources/corpus/d/yoga1-04-01-2.ednresources/corpus/d/yoga1-16-01-1.ednresources/corpus/d/yoga1-16-08-2.ednresources/corpus/d/yoga1-17-09-6.ednresources/corpus/d/yoga1_12-09-11-4.ednresources/corpus/d/yoga1_12-10-04-0.ednresources/corpus/d/yoga1_12-16-06-1.ednresources/corpus/d/yoga1_12-19-00-2.ednresources/corpus/e/template-01-06-0.ednresources/corpus/f/template-00-03-0.ednresources/corpus/i/template-01-07-0.ednresources/corpus/j/template-01-02-0.ednresources/corpus/j/template-04-00-0.ednresources/corpus/j/template-04-04-0.ednresources/corpus/j/yoga1-17-09-4.ednresources/corpus/l/yoga1-16-08-3.ednresources/corpus/l/yoga1-17-09-3.ednresources/corpus/m/template-01-00-0.ednresources/corpus/m/template-04-01-1.ednresources/corpus/m/template-04-02-0.ednresources/corpus/n/template-01-01-0.ednresources/corpus/n/yoga1_12-10-09-4.ednresources/corpus/o/template-01-05-1.ednresources/corpus/o/template-03-02-1.ednresources/corpus/o/template-04-01-0.ednresources/corpus/o/template-04-02-1.ednresources/corpus/o/template-04-04-2.ednresources/corpus/o/yoga1-16-08-1.ednresources/corpus/o/yoga1_12-03-06-0.ednresources/corpus/p/template-00-00-0.ednresources/corpus/p/template-02-00-1.ednresources/corpus/p/template-03-00-0.ednresources/corpus/p/template-03-01-0.ednresources/corpus/p/template-03-02-0.ednresources/corpus/r/template-03-02-3.ednresources/corpus/r/yoga1_12-08-04-3.ednresources/corpus/r/yoga1_12-09-06-3.ednresources/corpus/r/yoga1_12-16-01-2.ednresources/corpus/s/template-01-03-0.ednresources/corpus/s/template-04-02-2.ednresources/corpus/s/template-04-03-0.ednresources/corpus/t/template-00-01-0.ednresources/corpus/t/template-02-01-0.ednresources/corpus/t/template-03-00-2.ednresources/corpus/t/template-03-01-1.ednresources/corpus/t/template-04-03-3.ednresources/corpus/t/yoga1-17-08-2.ednresources/corpus/t/yoga1-17-09-5.ednresources/corpus/t/yoga1_12-10-02-3.ednresources/corpus/v/yoga1_12-03-06-2.ednresources/corpus/ţ/template-01-08-0.ednsrc/steno/converter.lpysrc/steno/core.lpysrc/steno/corpus.lpysrc/steno/show.lpy
✅ Files skipped from review due to trivial changes (52)
- resources/corpus/o/yoga1-16-08-1.edn
- resources/corpus/i/template-01-07-0.edn
- resources/corpus/c/template-04-04-3.edn
- resources/corpus/m/template-01-00-0.edn
- resources/corpus/j/yoga1-17-09-4.edn
- resources/corpus/o/template-04-04-2.edn
- resources/corpus/j/template-04-00-0.edn
- resources/corpus/r/yoga1_12-16-01-2.edn
- resources/corpus/f/template-00-03-0.edn
- resources/corpus/a/template-02-01-1.edn
- resources/corpus/t/template-02-01-0.edn
- resources/corpus/s/template-01-03-0.edn
- resources/corpus/ţ/template-01-08-0.edn
- resources/corpus/o/template-03-02-1.edn
- resources/corpus/j/template-01-02-0.edn
- resources/corpus/o/template-04-02-1.edn
- resources/corpus/n/template-01-01-0.edn
- resources/corpus/p/template-03-00-0.edn
- resources/corpus/d/yoga1_12-19-00-2.edn
- resources/corpus/a/template-02-00-0.edn
- resources/corpus/t/yoga1-17-09-5.edn
- resources/corpus/l/yoga1-16-08-3.edn
- resources/corpus/c/yoga1_12-03-06-1.edn
- resources/corpus/d/yoga1_12-09-11-4.edn
- resources/corpus/o/template-04-01-0.edn
- resources/corpus/l/yoga1-17-09-3.edn
- resources/corpus/d/yoga1_12-10-04-0.edn
- resources/corpus/t/yoga1_12-10-02-3.edn
- resources/corpus/a/template-04-03-1.edn
- resources/corpus/t/template-00-01-0.edn
- resources/corpus/p/template-03-01-0.edn
- resources/corpus/n/yoga1_12-10-09-4.edn
- resources/corpus/a/template-03-00-1.edn
- resources/corpus/s/template-04-03-0.edn
- resources/corpus/d/yoga1-04-01-2.edn
- resources/corpus/r/template-03-02-3.edn
- resources/corpus/j/template-04-04-0.edn
- resources/corpus/p/template-03-02-0.edn
- resources/corpus/a/template-05-01-0.edn
- resources/corpus/v/yoga1_12-03-06-2.edn
- resources/corpus/r/yoga1_12-09-06-3.edn
- resources/corpus/d/yoga1-17-09-6.edn
- resources/corpus/a/template-01-04-1.edn
- resources/corpus/p/template-02-00-1.edn
- resources/corpus/c/yoga1_12-10-02-2.edn
- resources/corpus/d/yoga1_12-16-06-1.edn
- resources/corpus/t/yoga1-17-08-2.edn
- resources/corpus/c/template-00-02-0.edn
- resources/corpus/r/yoga1_12-08-04-3.edn
- resources/corpus/m/template-04-02-0.edn
- resources/corpus/o/template-01-05-1.edn
- resources/corpus/o/yoga1_12-03-06-0.edn
🚧 Files skipped from review as they are similar to previous changes (10)
- resources/corpus/p/template-00-00-0.edn
- resources/corpus/t/template-04-03-3.edn
- resources/corpus/d/yoga1-16-01-1.edn
- resources/corpus/t/template-03-01-1.edn
- resources/corpus/d/yoga1-16-08-2.edn
- resources/corpus/t/template-03-00-2.edn
- resources/corpus/s/template-04-02-2.edn
- resources/corpus/e/template-01-06-0.edn
- resources/corpus/m/template-04-01-1.edn
- src/steno/corpus.lpy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.