Windows thumbnail shell extension#1569
Merged
Merged
Conversation
Member
askmeaboutlo0m
left a comment
There was a problem hiding this comment.
Looks good, only the ORDER BY snapshot_id DESC is functionally relevant, the rest is whatever.
SPDX-License-Identifier commands would also be nice to make it explicit. Just // SPDX-License-Identifier: GPL-3.0-or-later or // SPDX-License-Identifier: MIT or some other compatible thing at the top is fine. The Microsoft thumbnailer samples are MIT-licensed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
drawpile_shell_ext.dllon windows. This is a shell extension that provides thumbnails for.dpcsfiles.The WIX installer has been updated to register the DLL as a shell extension.
The code is self contained, only relying on windows libraries (WRL for COM) and sqlite3. WIC (Windows Imaging Component) is used to parse the JPEG thumbnail inside the
.dpcsfile.The PR also contains a simple test exe that loads the provider via COM and outputs a single thumbnail. I used it to test the shell extension and use a debugger, without having to rely on the file explorer.
The extension can be expanded in the future to support more file formats or other windows integration.
Formalities
I did use LLMs to understand various windows APIs.