Skip to content

Conversation

@kenny-not-dead
Copy link
Contributor

@kenny-not-dead kenny-not-dead commented Dec 18, 2025

close #xxx

It's clear that your project is popular and used worldwide. Each country has its own linguistic peculiarities, so I would suggest having the most flexible font settings.
For example, out of 15 fonts currently available, only 4 is used most often in my country, and most of the existing ones cannot be used.

Considering the project offers a wide range of customization options for most features, it seems like this wouldn't be a bad idea. I understand that your goal was to prevent the deletion of default fonts, but they could likely be customized by some of your users.

up to you

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

@jikkai
Copy link
Member

jikkai commented Dec 25, 2025

It seems a bit strange to dynamically delete fonts through the facade API. I assume what you actually need is to remove those built-in "useless" Chinese fonts :)
If that’s the case, allowing a custom font list to completely override the built-in one would be a more appropriate implementation.

@jikkai
Copy link
Member

jikkai commented Dec 25, 2025

I have opened a new PR that extends the customFontFamily configuration, allowing users to completely override the built-in font list. Does this meet your requirements? #6375

@kenny-not-dead
Copy link
Contributor Author

Thanks a lot, it's great)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants