feat: add remove fonts to facade #6344
Closed
+19
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #xxx
It's clear that your project is popular and used worldwide. Each country has its own linguistic peculiarities, so I would suggest having the most flexible font settings.
For example, out of 15 fonts currently available, only 4 is used most often in my country, and most of the existing ones cannot be used.
Considering the project offers a wide range of customization options for most features, it seems like this wouldn't be a bad idea. I understand that your goal was to prevent the deletion of default fonts, but they could likely be customized by some of your users.
up to you
Pull Request Checklist