Skip to content

Fixed incorrect type in Lagoon for database2.#2335

Merged
AlexSkrypnyk merged 1 commit intomainfrom
feature/fix-migrations-config
Mar 3, 2026
Merged

Fixed incorrect type in Lagoon for database2.#2335
AlexSkrypnyk merged 1 commit intomainfrom
feature/fix-migrations-config

Conversation

@AlexSkrypnyk
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk commented Mar 3, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated database service configuration labels for improved clarity and consistency.
    • Enhanced port mapping documentation with inline comments to help users identify service ports.

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f0d4645 and b3a2bb0.

⛔ Files ignored due to path filters (8)
  • .vortex/installer/tests/Fixtures/handler_process/migration_download_source_acquia/docker-compose.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_download_source_ftp/docker-compose.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_download_source_lagoon/docker-compose.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_download_source_s3/docker-compose.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_download_source_url/docker-compose.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled/docker-compose.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/docker-compose.yml is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/docker-compose.yml is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (5)
  • .vortex/tests/phpunit/Fixtures/docker-compose.env.json
  • .vortex/tests/phpunit/Fixtures/docker-compose.env_local.json
  • .vortex/tests/phpunit/Fixtures/docker-compose.env_mod.json
  • .vortex/tests/phpunit/Fixtures/docker-compose.noenv.json
  • docker-compose.yml

Walkthrough

Updated the lagoon.type label for the database2 service from "none" to "mariadb" across multiple docker-compose fixture files, and added inline comments to port mappings in the main docker-compose.yml configuration file.

Changes

Cohort / File(s) Summary
Test Fixture Configurations
.vortex/tests/phpunit/Fixtures/docker-compose.env.json, .vortex/tests/phpunit/Fixtures/docker-compose.env_local.json, .vortex/tests/phpunit/Fixtures/docker-compose.env_mod.json, .vortex/tests/phpunit/Fixtures/docker-compose.noenv.json
Updated lagoon.type label for database2 service from "none" to "mariadb" across all fixture files.
Main Compose Configuration
docker-compose.yml
Updated lagoon.type label for database2 service from "none" to "mariadb"; added inline comments to database and database2 port mappings describing the container port usage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through configs bright,
From "none" to "mariadb" in sight,
With labels fixed and comments clear,
The database setup's standing here! 🎉
Five files updated, all aligned—
Configuration perfection, by design!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fixed incorrect type in Lagoon for database2' directly and specifically describes the main change: correcting the lagoon.type label from 'none' to 'mariadb' for the database2 service across multiple fixture files and docker-compose.yml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/fix-migrations-config

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Code Coverage Report:
  2026-03-03 04:30:35

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-03 04:31:51

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-03 04:35:22

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-03-03 04:35:26

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.36%. Comparing base (d318285) to head (b3a2bb0).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2335      +/-   ##
==========================================
- Coverage   78.87%   78.36%   -0.52%     
==========================================
  Files         124      117       -7     
  Lines        6482     6323     -159     
  Branches       44        0      -44     
==========================================
- Hits         5113     4955     -158     
+ Misses       1369     1368       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk AlexSkrypnyk merged commit e66c974 into main Mar 3, 2026
34 of 35 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/fix-migrations-config branch March 3, 2026 05:00
@github-project-automation github-project-automation bot moved this from BACKLOG to Release queue in Vortex Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

1 participant