Skip to content

Conversation

@GerardPaligot
Copy link
Contributor

@GerardPaligot GerardPaligot commented Jan 28, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211850753229323/task/1212992299141099?focus=true

Description

When we are using Search & Duck.ai mode in browser screen, instead of the Search only mode, we should display the hamburger menu instead of the 3 dots icon.

Steps to test this PR

Search & Duck.ai mode

  • Open the application
  • Turn on experimental browser menu in Appearance settings
  • Turn on Search & Duck.ai mode in AI features settings
  • Go back to browser screen
  • Tap on the address bar
  • Check the hamburger icon replaced 3 dots icon
  • Tap on the hamburger menu
  • Check the bottom sheet is opened

UI changes

Before After
image image

Note

Adds bottom sheet menu awareness to the Input Screen and updates its menu icon accordingly.

  • Extends InputScreenActivityParams with useBottomSheetMenu and passes it from BrowserTabFragment.launchInputScreen
  • InputScreenFragment sets the menu icon on load via updateMenuIconButton (hamburger for bottom sheet, vertical dots otherwise)
  • InputModeWidget now exposes setMenuIcon and wires browserMenuImageView to allow dynamic icon updates

Written by Cursor Bugbot for commit 5eb5fa3. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

ContextCompat.getDrawable(context, resId)?.let {
menuIconImageView.setImageDrawable(it)
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overly complex icon setting using unnecessary indirection

Low Severity

The setMenuIcon function uses ContextCompat.getDrawable(context, resId)?.let { menuIconImageView.setImageDrawable(it) } when the simpler menuIconImageView.setImageResource(resId) would work. This pattern is inconsistent with InputScreenButtons.setSendButtonIcon in the same module, which directly uses setImageResource(iconResId). The null-safe ?.let is also unnecessary since the resource IDs passed are valid hardcoded constants.


Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants