This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Authv2 / handle 404 in Subscription API request #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/Subscription/API/SubscriptionEndpointServiceV2.swift # Sources/Subscription/Flows/AppStore/AppStorePurchaseFlowV2.swift # Sources/Subscription/Managers/SubscriptionManagerV2.swift # Sources/Subscription/Storage/V2/SubscriptionTokenKeychainStorage+LegacyAuthTokenStoring.swift # Sources/Subscription/Storage/V2/SubscriptionTokenKeychainStorageV2.swift # Sources/Subscription/SubscriptionFeatureV2.swift
federicocappelli
commented
Feb 3, 2025
| return try await storeAndAddFeaturesIfNeededTo(subscription: subscription) | ||
| } else { | ||
| if statusCode == .badRequest { | ||
| if statusCode == .badRequest || statusCode == .notFound { |
Member
Author
There was a problem hiding this comment.
this is the only change in this PR, the rest will disappear as soon the other PRs are merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1209234087255045/f
iOS PR: -
macOS PR: -
What kind of version bump will this require?: None
Description:
/subscriptionAPI request now can handle both 400 and 404 as a "no subscription available" instead than only 400.Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template