This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Add History Debug Menu on macOS and display only 1 week of history when history view is enabled #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/72649045549333/1209328755192085
iOS PR: duckduckgo/iOS#3930
macOS PR: duckduckgo/macos-browser#3833
What kind of version bump will this require?: Minor
Description:
Add
HistoryCoordinatingDebuggingSupportprotocol that defines addVisit functiontaking 2 parameters and allowing to add a visit at an arbitrary time, rather than
at current timestamp. This is required to be able to populate History with fake
data in client apps.
We already use a similar approach with SyncDependencies, where
SyncDependenciesDebuggingSupport protocol is defined to support debug menus.
Steps to test this PR:
Verify that CI is green.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template