[24299] Add fallback branch for master links (backport #1241)#1250
Open
mergify[bot] wants to merge 1 commit into3.2.xfrom
Open
[24299] Add fallback branch for master links (backport #1241)#1250mergify[bot] wants to merge 1 commit into3.2.xfrom
mergify[bot] wants to merge 1 commit into3.2.xfrom
Conversation
* Add first version of build with master fallback Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Minor branch fix Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Separate python_branch and python fallback branch Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update repos Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add same fallback logic as in ReadTheDocs checkouts and logs Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Changes substitution-block per code-block Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix refs Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Tests with read the docs env variables Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Resolving problem when building from RTD Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Apply review Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> (cherry picked from commit 60e9c7d) # Conflicts: # docs/conf.py # docs/fastddsgen/rpc_calculator_basic_app/includes/app.rst # docs/fastddsgen/rpc_calculator_basic_app/intro.rst # docs/fastddsgen/rpc_calculator_feed_app/includes/app.rst # docs/fastddsgen/rpc_calculator_feed_app/intro.rst # docs/fastddsgen/usage/usage.rst # docs/installation/configuration/cmake_options.rst
Author
|
Cherry-pick of 60e9c7d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix GitHub links in the documentation to always point to the correct branch instead of defaulting master/main
get_git_branch() now reads READTHEDOCS_VERSION on RTD builds (for branch and tag builds) instead of relying on git name-rev, which returned weird names like "external-1234". There are 3 possible cases for RTD builds now:
@Mergifyio backport 3.5.x 3.4.x 3.2.x 2.14.x
Contributor Checklist
Proversion badge has been added if the documented feature is exclusive to Fast DDS Pro.Reviewer Checklist
This is an automatic backport of pull request #1241 done by [Mergify](https://mergify.com).