Skip to content

fix syntax error#53

Closed
ga111o wants to merge 8 commits intoDevfrom
ga111o-patch-1
Closed

fix syntax error#53
ga111o wants to merge 8 commits intoDevfrom
ga111o-patch-1

Conversation

@ga111o
Copy link
Copy Markdown
Member

@ga111o ga111o commented Apr 9, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Resolved workflow configuration syntax issue to ensure proper script execution.

charlie3965 and others added 8 commits March 19, 2026 17:29
@charlie3965 @kwonkwonn
Change deployment image and add environment variables
f190ace 
Updated the deployment workflow to use the control_dev image and added environment variables for the container.
@charlie3965 @kwonkwonn
Change CONTROL_DEPLOY port from 8081 to 8083
d7be868
@kwonkwonn @wind5052 @ga111o
Migration build error resolved (#44)
d564886 
* file change : api

* migrate ambigious directory name request into client

* Add pkg directory for containing lower bound dependancy-free packages (#42)

Merge pkg structure migration to Control logic.

None of functional changes has applied but, structural refactoring for reduce of dependency  has been applied.

* resolve previous build error

---------

Co-authored-by: wind5052 <wind5052@naver.com>
Co-authored-by: Minhyeok <ga111o@proton.me>
@ga111o @kwonkwonn
feat: blackbox io test
36c7567
@ukleon123 @ga111o
update. action checkout version
bc27002
@ukleon123 @ga111o
feat. build verification workflow for pull request.
827bec0
@ukleon123 @coderabbitai @ga111o
Update .github/workflows/pr-build-check.yaml
01a7311 
Change Build fail review action 'REQUEST_CHANGES' to 'COMMENT'

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@ga111o
fix syntax error
b1eb4f1
@ga111o ga111o changed the base branch from main to Dev April 9, 2026 03:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 16ade836-d533-435f-a897-f826877282c3

📥 Commits

Reviewing files that changed from the base of the PR and between 01a7311 and b1eb4f1.

📒 Files selected for processing (1)
  • .github/workflows/pr-build-check.yaml
💤 Files with no reviewable changes (1)
  • .github/workflows/pr-build-check.yaml
📝 Walkthrough

Walkthrough

A one-line syntax fix in the GitHub Actions workflow script removing a duplicate closing bracket (});) that was causing malformed JavaScript in the pr-build-check workflow, restoring proper script termination.

Changes

Cohort / File(s) Summary
Workflow Syntax Fix
.github/workflows/pr-build-check.yaml		 Removed duplicate closing bracket from actions/github-script step, correcting malformed JavaScript syntax.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

🐰 A bracket too many caused quite the fright,
But one careless }); removed set it right,
The workflow now flows with syntax so true,
This little fix makes the build checks anew! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix syntax error' directly matches the primary change: removing a malformed closing delimiter in a workflow script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ga111o-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

github-code-quality[bot]
github-code-quality bot found potential problems Apr 9, 2026
View reviewed changes
tests/mock_core.py
self.end_headers()
self.wfile.write(body)

def do_GET(self):
tests/mock_core.py
return self._respond(VM_STATUS_RESP)
self._respond(GENERIC_RESP)

def do_POST(self):
@ga111o
Copy link
Copy Markdown
Member Author

ga111o commented Apr 9, 2026

이런.. workflow파일 문법 오류 있길래 모바일로 편집후 pr올렸더니 뭔가뭔가가 발생했군요..
이 pr은 닫고 컴퓨터로 수정 후 멀쩡한 pr 올려보겠습니다

@ga111o ga111o closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ga111o @charlie3965 @kwonkwonn @ukleon123