You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Still fails!
This time, some obscure dependency of one of the modules fails to build properly on 3.14 untokenize fails.
It's known and reported myint/untokenize#4
This dependency is pulled by docformatter, used in dev environment, so quite pervasive. docformatter is also aware of this issue PyCQA/docformatter#327 which they apparently fixed but not yet released.
Ruff format is not really a replacement for docformatter - the latter handles some more important docstring-specific formatting checks.
I’m aware of the current issue with docformatter and its dependency not supporting Python 3.14. Also, docformatter doesn’t handle Args and Returns sections in Google-style docstrings.
Because of that, I started looking into alternatives. It turns out that Google style is not that well supported in general, while NumPy style has much better support.
I tested this in the templates (in a separate branch) and found NumPy style to be better covered. So I switched to another package, format-docstring, instead of docformatter. It has good support for NumPy-style docstrings.
This means that moving to Python 3.14 should be possible by parallel switching the docstring formatter and reformatting docstrings to a better-supported style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebased against current develop
h5py with 3.14 support is already on pypi, so this should be straightforward.