feat: "Holy Shit!" when one "wins" after match end#75
Open
WofWca wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
holyshit-2.mp4
I also have this MR as a dedicated repo https://github.com/WofWca/quake3-holyshit-mod, you may read its README.
On how to easily test this, refer to https://github.com/WofWca/quake3-holyshit-mod#development-testing.
To be clear: gameplay-wise this doesn't change anything that's happening before
LogExit()has been called (and thusintermissionQueuedhas been set).I believe that the implementation is quite conservative and should not erroneously trigger the "Holy Shit!" sound to play.
This is somewhat related to #74, but in fact is completely independent, and will work either way, regardless of whether that MR gets merged.