Skip to content

Conversation

@vinokurig
Copy link
Contributor

What does this PR do?

Add a check that compared stored and new gitconfig data on input. If the entered gitconfig data matches with stored data, disable the Save button.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23625

Is it tested? How?

  1. Apply the dashboard pull request image: quay.io/eclipse/che-dashboard:pr-
  2. Go to User Preferences dialog -> Gitconfig tab.
  3. Enter username and email if empty, store the new data, see: the Save button is disabled.
  4. Change the gitconfig data, username or email, see: the Save button is enabled.

Release Notes

Docs PR

@openshift-ci
Copy link

openshift-ci bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@che-bot
Copy link
Contributor

che-bot commented Dec 4, 2025

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1426

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1426", name: che-dashboard}]}}]"

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.12%. Comparing base (3ad6fa5) to head (070398e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...src/pages/UserPreferences/GitConfig/Form/index.tsx 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
- Coverage   92.23%   92.12%   -0.12%     
==========================================
  Files         511      511              
  Lines       47614    47639      +25     
  Branches     3438     3432       -6     
==========================================
- Hits        43918    43888      -30     
- Misses       3657     3711      +54     
- Partials       39       40       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Save' button is not disabled when set 'user gitconfig' data in 'UserPreferences' on Dashboard

3 participants