Refactor linker script to use SRAM_U#402
Open
vladyslavmarkovaccenture wants to merge 1 commit intoeclipse-openbsw:mainfrom
Open
Refactor linker script to use SRAM_U#402vladyslavmarkovaccenture wants to merge 1 commit intoeclipse-openbsw:mainfrom
vladyslavmarkovaccenture wants to merge 1 commit intoeclipse-openbsw:mainfrom
Conversation
vladyslavmarkovaccenture
force-pushed
the
linker-script
branch
from
b734320 to
3e27afe
Compare
Contributor
Author
|
|
vladyslavmarkovaccenture
force-pushed
the
linker-script
branch
from
3e27afe to
c5693ba
Compare
Contributor
Author
|
Should be fine now. Tested on my HW. Please, test AND review. |
vladyslavmarkovaccenture
force-pushed
the
linker-script
branch
from
c5693ba to
7070c23
Compare
| *(COMMON) | ||
| *(EXCLUDE_FILE( | ||
| *app.o | ||
| *TransportSystem.o |
Contributor
There was a problem hiding this comment.
Do we really want to list all the object files here and commit to maintain that list?
Is the the only way?
Contributor
|
This PR mixes a few changes together:
This makes it hard to review. Can you split this into individual PRs please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor linker script to utilize SRAM_U and make space for future demo functionality.