refactor: extract shared CMSIS to libs/3rdparty/cmsis#445
Conversation
Move CMSIS 6.1.0 headers from platforms/s32k1xx/bsp/bspMcu/include/3rdparty/cmsis/ to libs/3rdparty/cmsis/ so that future Cortex-M platforms (e.g. STM32) can share the same CMSIS core without duplication. Changes: - Move 9 CMSIS files (core_cm4.h, cmsis_compiler.h, cmsis_gcc.h, cmsis_clang.h, cmsis_version.h, m-profile/armv7m_mpu.h, m-profile/cmsis_gcc_m.h, m-profile/cmsis_clang_m.h, LICENSE) to libs/3rdparty/cmsis/ - Add libs/3rdparty/cmsis/module.spec following the googletest pattern (unit_test: false, format_check: false, oss: true) - Update platforms/s32k1xx/bsp/bspMcu/CMakeLists.txt to add the new libs/3rdparty/cmsis/ and libs/3rdparty/cmsis/m-profile/ paths to target_include_directories - Update platforms/s32k1xx/bsp/bspMcu/include/mcu/mcu.h: change hardcoded path '3rdparty/cmsis/core_cm4.h' to bare 'core_cm4.h' (resolved via new include path) - Remove CMSIS entries from platforms/s32k1xx/bsp/bspMcu/module.spec exclude globs (CMSIS files are no longer under this module) - Consolidate NOTICE.md: single CMSIS entry pointing to libs/3rdparty/cmsis/LICENSE Verified: - s32k148 FreeRTOS cross-compile succeeds (app.referenceApp.elf produced, 231 KB text + 100 KB BSS) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Libs under libs/3rdparty mostly have .riminfo files available to be able to check consistency with upstream. Can you provide that one also? |
Fix treefmt CI gate on PR eclipse-openbsw#445. cmake-format collapses target_include_directories arguments onto fewer lines than the manual layout produced. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Hi @rolandreichweinbmw — quick question before producing the Two options:
Which would you prefer? Also pushed |
I propose (a). Checksumming and providing traceability to a certain upstream version/commit is the whole point of RIM. |
Summary
Moves CMSIS 6.1.0 headers from `platforms/s32k1xx/bsp/bspMcu/include/3rdparty/cmsis/` to `libs/3rdparty/cmsis/` so that future Cortex-M platforms can share the same CMSIS core without duplication.
This is the preparatory refactor referenced in PR #413 discussion and the strategy doc under `docs/stm32-pr-strategy.md` on the STM32 series branch.
Changes
Non-goals
Test plan
🤖 Generated with Claude Code