Middleware concurrency interface changes#462
Merged
rolandreichweinbmw merged 2 commits intoMay 27, 2026
Merged
Conversation
lcastela
force-pushed
the
ApplyMiddlewareConcurrencyPatch
branch
from
bbe6cbc to
ff224a7
Compare
Contributor
|
Content-wise, looks fine to me. Can you please craft the commit message according to |
lcastela
changed the title
lcastela
force-pushed
the
ApplyMiddlewareConcurrencyPatch
branch
2 times, most recently
from
07cc8fb to
e0b3a0d
Compare
rolandreichweinbmw
previously approved these changes
May 26, 2026
Move concrete lock type definitions out of LockStrategies.h and into a separate lock_types.h header. This allows platform integrations to provide ScopedCoreLock and ScopedECULock at build time.
The call to `suspendAllInterrupts()` in `ProxyBase` and `SkeletonBase` was redundant. After logging the cross-thread violation, both call sites unconditionally hit an assert, which is not recoverable.
lcastela
force-pushed
the
ApplyMiddlewareConcurrencyPatch
branch
from
143b221 to
1794d86
Compare
rolandreichweinbmw
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.