Add vajson to score baselibs#139
Open
JuriSchroeder wants to merge 28 commits intoeclipse-score:mainfrom
Open
Conversation
JuriSchroeder
requested review from
LittleHuba,
castler,
hoe-jo,
nradakovic and
ramceb
as code owners
JuriSchroeder
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
JuriSchroeder
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
|
The created documentation from the pull request is available at: docu-html |
JuriSchroeder
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
JuriSchroeder
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
JuriSchroeder
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
JuriSchroeder
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
JuriSchroeder
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
JuriSchroeder
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
JuriSchroeder
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
JuriSchroeder
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
Contributor
|
I think we should avoid using amsr and replace it with score namespace |
JuriSchroeder
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
JuriSchroeder
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
JuriSchroeder
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
JuriSchroeder
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
JuriSchroeder
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
JuriSchroeder
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
JuriSchroeder
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
JuriSchroeder
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
Contributor
Author
|
@mihajlo-k @fbaeuerle This PR is ready for review. The failing copyright check is pointing to a file that is not changed as part of this PR. Let me know if something needs changing. |
fbaeuerle
reviewed
Apr 22, 2026
| build --credential_helper="*.qnx.com=%workspace%/.github/tools/qnx_credential_helper.py" | ||
|
|
||
| build:_bl_stub --//score/json:base_library=nlohmann | ||
| build:_bl_stub --//score/json:base_library=vajson |
Contributor
There was a problem hiding this comment.
Does this change need project alignment?
Contributor
Author
There was a problem hiding this comment.
I guess so. I can also just revert it for now.
Contributor
Author
There was a problem hiding this comment.
@fbaeuerle I switched back to using nlohmann as default.
| [&result](StringView view) noexcept { | ||
| static_cast<void>(std::memcpy(&result, view.data(), sizeof(result))); | ||
|
|
||
| result = be32toh(result); |
Contributor
There was a problem hiding this comment.
out of curiosity: why can't we use be32toh?
Contributor
Author
There was a problem hiding this comment.
IIRC it caused build failures on QNX because the macro is not defined there.
Contributor
The problem is anyway already fixed on master. I cannot rerun it (neither can I approve the qnx workflows). |
JuriSchroeder
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
JuriSchroeder
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
JuriSchroeder
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
JuriSchroeder
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
JuriSchroeder
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
JuriSchroeder
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
JuriSchroeder
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
JuriSchroeder
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
JuriSchroeder
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
JuriSchroeder
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the vector VaJson Parser to the score baselibs. Treats #149