Bgsw baselib ut reviewfinding fix#185
Closed
Rutuja-Patil-Bosch wants to merge 20 commits into
Closed
Conversation
…lse_isValidDateTimeFormat EpochToDateTime_Before1970_LeapYear_January_AdjustsDaysSum invalid_day_values invalid_month_values
removed redundnat checks
Feature: bgsw_baselib_ut
This PR addresses findings observed in the review of eclipse-score#135
1. The yearIsLeap() function expects a uint16_t argument, but you're passing an int. When strict warnings are enabled, this type mismatch is treated as a compilation error.
-> This logic is removed & test cases are updated with fixed input values instead of for loop
2. "Negative" isn't one of the applicable values https://eclipse-score.github.io/process_description/main/process_areas/verification/guidance/verification_specification.html#test-specification
-> as per spec & discussion in followed comments updated as "requirements-based"
3. Those properties are not part of the test specification https://eclipse-score.github.io/process_description/main/process_areas/verification/guidance/verification_specification.html#test-specification
-> Removed these additional properties
4. this is dead code
-> Test cases are updated as dead code was not for all the conditions. Due to for loop, it was was dead code for few iteration. Removed for loop & tested for exact values.
Rutuja-Patil-Bosch
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
Rutuja-Patil-Bosch
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
|
The created documentation from the pull request is available at: docu-html |
Contributor
Author
|
I'll create this as part of #135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review findings are fixed for
-> This logic is removed & test cases are updated with fixed input values instead of for loop
-> as per spec & discussion in followed comments updated as "requirements-based"
-> Removed these additional properties
-> Test cases are updated as dead code was not for all the conditions. Due to for loop, it was was dead code for few iteration. Removed for loop & tested for exact values.