Fix NonNull creation in Placeholder::new function#90
Open
djerry96 wants to merge 1 commit into
Open
Conversation
Updated the creation of NonNull in the new function to avoid using an unstable feature. Signed-off-by: Daniel Nieto <djerry_96@hotmail.com>
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
pawelrutkaq
reviewed
Apr 29, 2026
| /// Create the placeholder to be represented using `ScoreDebug`. | ||
| pub const fn new<T: ScoreDebug>(value: &'a T, spec: FormatSpec) -> Self { | ||
| let value = NonNull::from_ref(value).cast(); | ||
| // Replaced previous line: let value = NonNull::from_ref(value).cast(); Due to error[E0658]: use of unstable library feature `non_null_from_ref` when building. Usage of NonNull::<T>::from_ref` is not yet stable as a const fn |
Contributor
There was a problem hiding this comment.
its stable from 1.89 or ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the creation of NonNull in the new function to avoid using an unstable feature.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #