fix: replace unstable NonNull::from_ref with stable equivalent#92
Open
pypingou wants to merge 2 commits into
Open
fix: replace unstable NonNull::from_ref with stable equivalent#92pypingou wants to merge 2 commits into
pypingou wants to merge 2 commits into
Conversation
Replace NonNull::from_ref usage in const fn context with stable
alternative using NonNull::new_unchecked.
The NonNull::from_ref method exists in Rust 1.86+ but using it as a
const fn is still unstable (requires nightly feature non_null_from_ref).
This change enables compilation with stable Rust toolchains including
Ferrocene.
Changes:
NonNull::from_ref(value).cast()
to:
unsafe { NonNull::new_unchecked(value as *const _ as *mut ()).cast() }
Both implementations are functionally equivalent and safe in this
context due to the lifetime constraints enforced by the borrow checker.
Enables: aarch64-linux builds with stable Ferrocene toolchain
Related: rust-lang/rust#130823
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pypingou
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
pypingou
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
10 tasks
The TryFrom<Vec<u8>> trait is not implemented for String, causing compilation errors on aarch64. Use String::from_utf8() which properly returns Result<String, FromUtf8Error>. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pypingou
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
pypingou
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace NonNull::from_ref usage in const fn context with stable alternative using NonNull::new_unchecked.
The NonNull::from_ref method exists in Rust 1.86+ but using it as a const fn is still unstable (requires nightly feature non_null_from_ref). This change enables compilation with stable Rust toolchains including Ferrocene.
Changes:
NonNull::from_ref(value).cast()
to:
unsafe { NonNull::new_unchecked(value as *const _ as *mut ()).cast() }
Both implementations are functionally equivalent and safe in this context due to the lifetime constraints enforced by the borrow checker.
Enables: aarch64-linux builds with stable Ferrocene toolchain
Related: rust-lang/rust#130823
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #