Add style-readability checks to clang-tidy config#392
Open
sahithi-nukala wants to merge 1 commit into
Open
Conversation
sahithi-nukala
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
limdor
reviewed
May 11, 2026
sahithi-nukala
force-pushed
the
sah_clang_readability_checks
branch
from
5b33a07 to
5242687
Compare
limdor
requested changes
May 12, 2026
Contributor
limdor
left a comment
limdor
left a comment
There was a problem hiding this comment.
I did not finish the review but I see several custom types missing. Please take a look to the other configs and add also the custom types.
sahithi-nukala
force-pushed
the
sah_clang_readability_checks
branch
2 times, most recently
from
a8ef2e4 to
eeee021
Compare
limdor
reviewed
May 13, 2026
| value: > | ||
| ::score::cpp::basic_string_view; | ||
| ::score::cpp::span; | ||
| ::score::safecpp::basic_zstring_view; |
Contributor
There was a problem hiding this comment.
Suggested change
| ::score::safecpp::basic_zstring_view; |
I got this wrong in the previous review. zstring_view is perfectly fine because it is guaranteed to be null terminated.
With so many checks it is hard to review. I tought I would be able to handle but it would be great if you could split it again and have a PR only with the # --- extra ---
sahithi-nukala
force-pushed
the
sah_clang_readability_checks
branch
from
eeee021 to
0041791
Compare
sahithi-nukala
force-pushed
the
sah_clang_readability_checks
branch
from
0041791 to
0928883
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.