mw/com[Bug]: fix infinite recursion in ProxyEvent move-assignment and Use After Free Bug.#399
Merged
Merged
Conversation
KrishaDeshkool
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
KrishaDeshkool
changed the title
bemerybmw
requested changes
May 8, 2026
bemerybmw
reviewed
May 8, 2026
KrishaDeshkool
force-pushed
the
fix_move_bug
branch
3 times, most recently
from
fd43915 to
d007548
Compare
Contributor
Author
|
if the raw pointer issue needs some more discussion and we need another way to fix then i would propose we split this PR into two and merge the first one and merge that. |
KrishaDeshkool
force-pushed
the
fix_move_bug
branch
from
d007548 to
9260259
Compare
KrishaDeshkool
changed the title
KrishaDeshkool
force-pushed
the
fix_move_bug
branch
from
9260259 to
b18b7a1
Compare
bemerybmw
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 Bugs in one go,
first one is the infinite recursion issue in the move op,
second one is the crash which was caused by holding a raw pointer and not managing its lifetime well in the move assignment operations.