Execute Integration Tests on QNX in CI#415
Conversation
castler
requested review from
LittleHuba,
bemerybmw,
crimson11,
hoe-jo and
limdor
as code owners
castler
force-pushed
the
js_execute__integration_tests_on_qnx
branch
from
6430452 to
b28f7ab
Compare
| git_override( | ||
| module_name = "score_bazel_cpp_toolchains", | ||
| commit = "79982259df6dfa9d82cc458163a6d9b08bd24471", | ||
| commit = "30d9f4151db55af066e5bbf8a0a3672469ec0293", |
There was a problem hiding this comment.
Why do we need this override? 0.5.1 is already having the commit that we are interested. In this case with the override we are removing 3 commits from the released version. Do we have an issue with any of these removed commits? If yes, was this reported to score_bazel_cpp_toolchains?
There was a problem hiding this comment.
I discussed in offline with @castler and this should not be needed. We agreed to do it in a follow up PR in this way we can have the failing tests fixed asap.
| bazel_dep(name = "rules_rust", version = "0.68.1-score") | ||
|
|
||
| # Patch baselibs with a QNX8 workaround for poll | ||
| # until a fix is provided by the QNX SDP |
There was a problem hiding this comment.
AFAIK this fix should be available in 8.0.4, if we add this information here it will be easier to remember when to remove the patch.
| name = "generated_api_test", | ||
| srcs = ["generated_api_test.cpp"], | ||
| features = COMPILER_WARNING_FEATURES, | ||
| target_compatible_with = ["@platforms//os:linux"], |
There was a problem hiding this comment.
Do we want to add a comment with the ticket to have QNX unit tests enabled? In this way it will be harder to forget about removing this once we have the ability to run them on QNX.
| srcs = [ | ||
| "command_line_parser_test.cpp", | ||
| ], | ||
| target_compatible_with = ["@platforms//os:linux"], |
There was a problem hiding this comment.
Do we want to add a comment with the ticket to have QNX unit tests enabled? In this way it will be harder to forget about removing this once we have the ability to run them on QNX.
Grant pathspace for nonroot domain before setuid
Apply -lstdc++ and -no-pie only for Linux builds.
These tests shall only be executed on Linux, as long as we do not have QNX Unit Tests enabled.
In order to have the correct direct version dependency as also transitive one.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
4 participants
No description provided.