Skip to content

feat: Satisfy some security gd_reqs#558

Merged
AlexanderLanin merged 5 commits into
eclipse-score:mainfrom
etas-contrib:satisfy-gd_req__sec_attr_
May 29, 2026
Merged

feat: Satisfy some security gd_reqs#558
AlexanderLanin merged 5 commits into
eclipse-score:mainfrom
etas-contrib:satisfy-gd_req__sec_attr_

Conversation

@a-zw
Copy link
Copy Markdown
Contributor

@a-zw a-zw commented May 27, 2026

📌 Description

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 48cacd2b-b787-4d9a-9310-be9ba1710adf
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 6.301s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

The created documentation from the pull request is available at: docu-html

@a-zw a-zw requested review from RolandJentschETAS and pahmann May 27, 2026 11:44
AlexanderLanin
AlexanderLanin previously approved these changes May 27, 2026
View reviewed changes
RolandJentschETAS
RolandJentschETAS reviewed May 28, 2026
View reviewed changes
Comment thread docs/internals/requirements/requirements.rst
RolandJentschETAS
RolandJentschETAS reviewed May 28, 2026
View reviewed changes
Comment thread src/extensions/score_metamodel/tests/rst/options/test_options_options.rst Outdated
RolandJentschETAS
RolandJentschETAS reviewed May 28, 2026
View reviewed changes
Comment thread src/extensions/score_metamodel/tests/rst/options/test_options_options.rst Outdated
RolandJentschETAS
RolandJentschETAS reviewed May 28, 2026
View reviewed changes
Comment thread src/extensions/score_metamodel/metamodel.yaml Outdated
AlexanderLanin
AlexanderLanin previously approved these changes May 28, 2026
View reviewed changes
MaximilianSoerenPollak
MaximilianSoerenPollak reviewed May 28, 2026
View reviewed changes
Comment thread docs/internals/requirements/requirements.rst
MaximilianSoerenPollak
MaximilianSoerenPollak reviewed May 28, 2026
View reviewed changes
Comment thread docs/internals/requirements/requirements.rst
MaximilianSoerenPollak
MaximilianSoerenPollak reviewed May 28, 2026
View reviewed changes
Comment thread docs/internals/requirements/requirements.rst Outdated
MaximilianSoerenPollak
MaximilianSoerenPollak reviewed May 28, 2026
View reviewed changes
Comment thread src/extensions/score_metamodel/metamodel.yaml Outdated
MaximilianSoerenPollak
MaximilianSoerenPollak previously requested changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments that need addressing

@a-zw a-zw force-pushed the satisfy-gd_req__sec_attr_ branch from 94c0c08 to 1f41085 Compare May 28, 2026 09:47
@a-zw a-zw force-pushed the satisfy-gd_req__sec_attr_ branch from 1f41085 to 9715b35 Compare May 28, 2026 09:52
AlexanderLanin
AlexanderLanin requested changes May 29, 2026
View reviewed changes
Comment thread docs/internals/requirements/requirements.rst Outdated
Comment thread src/extensions/score_source_code_linker/__init__.py Outdated
@a-zw a-zw force-pushed the satisfy-gd_req__sec_attr_ branch from 542ccb5 to 1625b13 Compare May 29, 2026 11:55
@a-zw a-zw requested a review from AlexanderLanin May 29, 2026 11:56
@AlexanderLanin
Copy link
Copy Markdown
Member

AlexanderLanin commented May 29, 2026

@a-zw please avoid force push, as now I cannot review the latest changes only

@AlexanderLanin AlexanderLanin merged commit 575b038 into eclipse-score:main May 29, 2026
11 of 13 checks passed
@AlexanderLanin AlexanderLanin deleted the satisfy-gd_req__sec_attr_ branch May 29, 2026 12:40
@a-zw a-zw mentioned this pull request May 29, 2026
Merged
a-zw added a commit to etas-contrib/score_docs-as-code that referenced this pull request May 29, 2026
@a-zw
fix: update tests
86911e7 
Added tests in eclipse-score#558 and in parallel modified tests in eclipse-score#564.
That created a conflict which only became obvious once both were merged
to main.
MaximilianSoerenPollak pushed a commit that referenced this pull request May 29, 2026
@a-zw
fix: update tests (#567)
d60ab62 
Added tests in #558 and in parallel modified tests in #564.
That created a conflict which only became obvious once both were merged
to main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderLanin AlexanderLanin AlexanderLanin approved these changes

@RolandJentschETAS RolandJentschETAS RolandJentschETAS left review comments

@dcalavrezo-qorix dcalavrezo-qorix Awaiting requested review from dcalavrezo-qorix dcalavrezo-qorix is a code owner

@nradakovic nradakovic Awaiting requested review from nradakovic nradakovic is a code owner

@pahmann pahmann Awaiting requested review from pahmann

@MaximilianSoerenPollak MaximilianSoerenPollak Awaiting requested review from MaximilianSoerenPollak MaximilianSoerenPollak is a code owner

Assignees

No one assigned

Labels

None yet

Projects

INF - Infrastructure Community
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a-zw @AlexanderLanin @MaximilianSoerenPollak @RolandJentschETAS