Initial integration tests#194
Open
WilliamRoebuck wants to merge 3 commits into
Open
Conversation
WilliamRoebuck
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
WilliamRoebuck
force-pushed
the
feature/integration-tests-1
branch
from
bfff457 to
784bdd7
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
|
The created documentation from the pull request is available at: docu-html |
* Add process args test eclipse-score#172 * Add run target switch test eclipse-score#174 * Add runtime crash test eclipse-score#177 * Add monitoring failure test eclipse-score#178 * Add crash on startup test eclipse-score#179
WilliamRoebuck
force-pushed
the
feature/integration-tests-1
branch
from
937434e to
f82bf7e
Compare
WilliamRoebuck
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
WilliamRoebuck
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
2 tasks
| int main() | ||
| { | ||
| deploy_and_crash_if_not_present("crashed_once"); | ||
| deploy_and_crash_if_not_present("crashed_twice"); |
Contributor
There was a problem hiding this comment.
Where are these files being cleaned up again?
| derivation_technique="requirements-analysis", | ||
| ) | ||
| def test_crash_on_startup(target, setup_test, test_output_dir, remote_test_dir): | ||
| """Integration test verifying that the launch manager correctly handles processes |
Contributor
There was a problem hiding this comment.
I think we need some more description of what is being tested here and what is the expected behaviour.
The process is asking for this information:
- The objective of the test.
- Inputs
- Expected outcome (e.g. “A success message is displayed.”)
- Test environment (e.g. network configuration, clean system state)
I know there is more info in control_client_mock.cpp available, but I assume we need this info in a test spec as part of a test report at least at a high level.
Maybe something like:
"""
Objective: Verifies that the launch manager correctly handles processes that crash before reporting kRunning.
Case 1: Process crashes before Running state but eventually starts up successfully before the configured number of restart attempts is exceeded.
Expected Behaviour: Process startup successful, RunTarget activation successful
Case 2: Process keeps crashing, exceeding the number of restart attempts.
Expected Behaviour: Process startup fails, LaunchManager executes recovery action.
"""| #include <score/lcm/control_client.h> | ||
| #include <score/lcm/lifecycle_client.h> | ||
|
|
||
| score::lcm::ControlClient client; |
Contributor
There was a problem hiding this comment.
After merging #191 we cannot create the ControlClient in global scope as mw::log might not be initialized yet and does not support logging at this point in time.
Same for all other tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the following tests:
Improvements/fixes to test helper & smoke test