Skip to content

add compile-time configuration for kvs maximum storage size#165

Open
atarekra wants to merge 9 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:kvs-compile-time-max-size-support
Open

add compile-time configuration for kvs maximum storage size#165
atarekra wants to merge 9 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:kvs-compile-time-max-size-support

Conversation

@atarekra
Copy link
Copy Markdown
Contributor

@atarekra atarekra commented Nov 9, 2025

This pull request introduces support for specifying the maximum size of the Key-Value Storage (KVS) at compile time, fulfilling the related requirement:

"The Key-Value-Storage shall support specification of its maximum size at compile time."

and resolves #161

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 9, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 3119bbee-707a-4774-9707-b9905884bc4e
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.4, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.2, but got rules_cc@0.2.16 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'google_benchmark', the root module requires module version google_benchmark@1.9.4, but got google_benchmark@1.9.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (72 packages loaded, 10 targets configured)

Analyzing: target //:license-check (145 packages loaded, 1007 targets configured)

Analyzing: target //:license-check (157 packages loaded, 1903 targets configured)

Analyzing: target //:license-check (168 packages loaded, 3497 targets configured)

Analyzing: target //:license-check (168 packages loaded, 3497 targets configured)

Analyzing: target //:license-check (168 packages loaded, 3497 targets configured)

Analyzing: target //:license-check (168 packages loaded, 3497 targets configured)

Analyzing: target //:license-check (171 packages loaded, 5386 targets configured)

Analyzing: target //:license-check (172 packages loaded, 5506 targets configured)

Analyzing: target //:license-check (199 packages loaded, 5722 targets configured)
[13 / 17] [Prepa] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes
Analyzing: target //:license-check (199 packages loaded, 5722 targets configured)
[13 / 17] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 1s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 66 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
Analyzing: target //:license-check (199 packages loaded, 5722 targets configured)
[15 / 17] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
Analyzing: target //:license-check (199 packages loaded, 5722 targets configured)
[16 / 17] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
Analyzing: target //:license-check (199 packages loaded, 5722 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 5726 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
INFO: Analyzed target //:license-check (202 packages loaded, 10170 targets configured).
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 41.319s, Critical Path: 3.69s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 9, 2025

The created documentation from the pull request is available at: docu-html

@Ahmed-Elsaka-JC
Copy link
Copy Markdown
Contributor

I see the following points :
user will face issue while flush to memory , i would say it would be better to let use know erlier while using set API to return error in case current storage size in ram exceed configured size.

Copy link
Copy Markdown
Contributor

@PandaeDo PandaeDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please solve all the build errors?

@atarekra
Copy link
Copy Markdown
Contributor Author

atarekra commented Feb 2, 2026

Could you please solve all the build errors?
Solved

@arkjedrz
Copy link
Copy Markdown
Contributor

I see this PR is up to date, but the change should be discussed.

@arkjedrz
Copy link
Copy Markdown
Contributor

Discussed during CFT 12.03.2026 - configuration of this parameter is okay, but the parameter should be init-time configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add compile-time configuration for maximum Key-Value Storage (KVS) size

4 participants