chore(calculate-shipping): add product list to validate rule #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leomp12
reviewed
Nov 10, 2023
Comment on lines
+322
to
+337
| "product_ids": { | ||
| "title": "Lista de produtos selecionados", | ||
| "description": "Se preenchido, a regra de envio estará disponível apenas se pelo menos um destes produtos estiver no carrinho", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string", | ||
| "pattern": "^[a-f0-9]{24}$", | ||
| "title": "ID do produto" | ||
| } | ||
| }, | ||
| "all_product_ids": { | ||
| "type": "boolean", | ||
| "title": "Checar todos os produtos", | ||
| "description": "Se ativo, a regra será disponibilizada apenas se todos os itens do carrinho estiverem na lista de produtos selecionados", | ||
| "default": false | ||
| }, |
Member
There was a problem hiding this comment.
Esse trem vai ser pouco usado, deveria estar no final da config da regra
| rule && | ||
| (!rule.service_code || rule.service_code === coProduto) && | ||
| checkZipCode(rule) && | ||
| (!rule.product_ids || hasProduct) && |
Member
There was a problem hiding this comment.
Suggested change
| (!rule.product_ids || hasProduct) && | |
| (!rule.product_ids || !rule.product_ids.length || hasProduct) && |
Comment on lines
+332
to
+337
| "all_product_ids": { | ||
| "type": "boolean", | ||
| "title": "Checar todos os produtos", | ||
| "description": "Se ativo, a regra será disponibilizada apenas se todos os itens do carrinho estiverem na lista de produtos selecionados", | ||
| "default": false | ||
| }, |
Member
There was a problem hiding this comment.
Precisa mesmo dessa segunda opção aqui? Quer dizer, tem cenário pra ambos os casos? Com algum produto na lista e com todos os produtos na lista?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.