Out-of-core support for Linux and macOS#6
Open
martinjankoehler wants to merge 2 commits intoediloren:masterfrom
Open
Out-of-core support for Linux and macOS#6martinjankoehler wants to merge 2 commits intoediloren:masterfrom
martinjankoehler wants to merge 2 commits intoediloren:masterfrom
Conversation
wxGetFreeMemory() does not work on UNIX platforms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original wxWidgets
wxGetFreeMemory()did work for Windows, but not on Linux or macOS, where just-1was returned:https://docs.wxwidgets.org/stable/group__group__funcmacro__networkuseros.html#ga295ff6a2681c806195447a920f681499
The replacement method
portableGetFreeMemory()is now implemented for Windows, Linux and macOS.