Skip to content

fix: issus with LMS instructor tab CSV register and enroll #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Waleed-Mujahid wants to merge 2 commits into
base: develop-teak
Choose a base branch
from
Open

fix: issus with LMS instructor tab CSV register and enroll #713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
391b92a
feat: Validate country input during student registration
Waleed-Mujahid Dec 1, 2025
4ffe461
feat: Trigger event on student registration completion
Waleed-Mujahid Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions lms/djangoapps/instructor/views/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import edx_api_doc_tools as apidocs
from django.conf import settings
from django.contrib.auth.models import User # lint-amnesty, pylint: disable=imported-auth-user
from django_countries.fields import Country
from django.core.exceptions import MultipleObjectsReturned, ObjectDoesNotExist, PermissionDenied, ValidationError
from django.core.validators import validate_email
from django.db import IntegrityError, transaction
Expand All @@ -37,6 +38,8 @@
from opaque_keys import InvalidKeyError
from opaque_keys.edx.keys import CourseKey, UsageKey
from openedx.core.djangoapps.course_groups.cohorts import get_cohort_by_name
from openedx_events.learning.data import UserData, UserPersonalData
from openedx_events.learning.signals import STUDENT_REGISTRATION_COMPLETED
from rest_framework.exceptions import MethodNotAllowed
from rest_framework import serializers, status # lint-amnesty, pylint: disable=wrong-import-order
from rest_framework.permissions import IsAdminUser, IsAuthenticated # lint-amnesty, pylint: disable=wrong-import-order
Expand Down Expand Up @@ -418,6 +421,14 @@ def post(self, request, course_id): # pylint: disable=too-many-statements
else:
cohort_name = None
course_mode = None

if not Country(country).name:
row_errors.append({
'username': username,
'email': email,
'response': _('Invalid country: {country}. Please enter a valid country code. e.g., US, GB').format(country=country)
})
continue

# Validate cohort name, and get the cohort object. Skip if course
# is not cohorted.
Expand Down Expand Up @@ -643,6 +654,18 @@ def create_user_and_user_profile(email, username, name, country, password):
profile.country = country
profile.save()

STUDENT_REGISTRATION_COMPLETED.send_event(
user=UserData(
pii=UserPersonalData(
username=user.username,
email=user.email,
name=user.profile.name,
),
id=user.id,
is_active=user.is_active,
),
)

return user


Expand Down
Loading