feat: implement edly login/registration flow #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Edly reducer and saga to the root reducer and saga respectively. - Updated LoginPage to utilize Edly's prefilled email feature and display EdlyAlert. - Enhanced Logistration component to conditionally render EmailCheckPage based on props. - Incorporated EdlyAlert in RegistrationPage for consistent user feedback.
- Updated EdlyAlert to directly render formatted messages without wrapping them in <p> tags initially. - Ensured consistent rendering by wrapping the final alert message in a <p> tag within the Alert component.
Waleed-Mujahid
force-pushed
the
waleed/8080
branch
from
f09dee9 to
9699b2e
Compare
Anas-hameed
requested changes
Dec 10, 2025
Comment on lines
+9
to
+19
| const initialState = { | ||
| email: '', | ||
| redirectTo: null, | ||
| message: null, | ||
| errorMessage: null, | ||
| submitState: DEFAULT_STATE, | ||
| showEmailCheck: true, | ||
| prefilledEmail: '', | ||
| errorCode: null, | ||
| context: {}, | ||
| }; |
There was a problem hiding this comment.
We should add a sub-level that identifies the specific component this reducer belongs to. The current edly namespace doesn’t indicate which component uses this code.
src/edly/data/reducers.js is not indicating the component hierarchy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edlyspecific logic in a separateedlydir to keep low core changesLogistrationpage to utilize Edly's prefilled email featureEdlyAlertto show info based on your'sEdlyMultiSiteAccessanderror_codereturned by backend apiTicket
https://projects.arbisoft.com/project/edly-product/task/8082
https://projects.arbisoft.com/project/edly-product/task/8089
Linked PR
https://github.com/edly-io/edly-features-app/pull/39