[DRAFT] revert redux state registry and session#3407
Draft
Conversation
This commit introduce the revert of the redux win.session mechanism (currently broken) to save the current session (one library, multiple reader) at closing. This remove also the reader registry persistence from the redux store, to rely on fileSystem publication directory index (appData/config-data/reader/<uuid>/...). Publication data preference will not be written in redux state in main process anymore, but instead written directly the disk. This allow to save massive data IO redux state persistence to disk by successive patches and final entire state dump. next steps: - migrate registry to appData config-data/reader/<uuid> directory - handle library bound in appData/config-data by getter/setter functions in main/di - read/write publication state bound/config/locator.json to appData config-data/reader/<uuid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduce the revert of the redux win.session mechanism (currently broken) to save the current session (one library, multiple reader) at closing.
This remove also the reader registry persistence from the redux store, to rely on fileSystem publication directory index (appData/config-data/reader//...). Publication data preference will not be written in redux state in main process anymore, but instead written directly the disk. This allow to save massive data IO redux state persistence to disk by successive patches and final entire state dump.
next steps: