Complete rewrite lol sorry - NiMBLE support and host/server support#77
Open
yinzara wants to merge 13 commits intoedrosten:masterfrom
Open
Complete rewrite lol sorry - NiMBLE support and host/server support#77yinzara wants to merge 13 commits intoedrosten:masterfrom
yinzara wants to merge 13 commits intoedrosten:masterfrom
Conversation
yinzara
changed the title
Owner
|
Hi! Thanks for the PR. As you may have noticed I've basically not touched the library in quite a while now. It looks like you've done a huge amount work on it. I don't really have the bandwidth to give this the review it deserves. I'm happy to hand over maintainership of this library to you if you'd prefer. I can host here and make you an admin on the repo, or I'm happy to archive it and point to a repo that you host. -Ed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You're welcome to completely ignore this PR and I'll maintain my own fork as this basically rewrites everything.
Previously you only supported HCI based Bluetooth devices which covers most but there are a set of devices that support the Apache NiMBLE stack https://github.com/apache/mynewt-nimble and https://github.com/gtxaspec/atbm-wifi that I think I are important to support.
Additionally your library was client side only. i.e. you could not act as a BLE host and expose services/characteristics. This PR adds that capability for both support transport platforms.