-
Notifications
You must be signed in to change notification settings - Fork 12
fix: update macOS image to latest and simplify colima start command #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the macOS GitHub Actions runner image and simplifies the colima Docker configuration command used in the CLI tests workflow.
Key Changes:
- Updates the macOS runner image from
macos-13tomacos-latest - Simplifies the colima start command by removing the
-a vz(virtualization framework) and-r docker(runtime) flags, retaining only memory configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/cli-tests.yml
Outdated
| run: | | ||
| brew install colima docker docker-compose | ||
| colima start -a vz -m 8 -r docker | ||
| colima start -m 8 |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of the -a vz and -r docker flags from the colima start command may cause unexpected behavior. The -a vz flag explicitly uses the Virtualization.framework which is faster and more reliable on macOS 13+. The -r docker flag ensures the docker runtime is used. Without these flags, colima will fall back to its defaults, which could be QEMU (slower) or a different runtime. Consider keeping these flags for explicit and consistent behavior, especially since the macOS image is now unversioned with macos-latest.
| colima start -m 8 | |
| colima start -m 8 -a vz -r docker |
.github/workflows/cli-tests.yml
Outdated
| image: ubuntu-24.04 | ||
| - name: mac | ||
| image: macos-13 | ||
| image: macos-latest |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using macos-latest instead of a pinned version like macos-13 introduces unpredictability. When GitHub updates what constitutes "latest", the CI environment will change without any code changes in this repository, potentially causing unexpected test failures. Consider pinning to a specific version (e.g., macos-14 or macos-15) for reproducible CI builds.
| image: macos-latest | |
| image: macos-14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/cli-tests.yml
Outdated
| brew install colima docker docker-compose | ||
| colima start -a vz -m 8 -r docker | ||
| brew install qemu colima docker docker-compose | ||
| colima start --vm-type qemu --memory 8 |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The colima start command is missing the runtime specification. The previous command used -r docker to explicitly set the runtime. Without this flag, colima may default to a different runtime (like containerd), which could cause the tests to fail. The runtime flag should be added back.
| colima start --vm-type qemu --memory 8 | |
| colima start -r docker --vm-type qemu --memory 8 |
.github/workflows/cli-tests.yml
Outdated
| colima start --vm-type qemu --memory 8 | ||
| echo "DOCKER_HOST=unix://${HOME}/.colima/docker.sock" >> $GITHUB_ENV | ||
| mkdir -p ~/.docker/cli-plugins | ||
| ln -sfn /usr/local/bin/docker-compose ~/.docker/cli-plugins/docker-compose |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching from the Apple Virtualization framework (vz) to QEMU may significantly degrade CI performance. The vz VM type uses native Apple Silicon virtualization (when available) which is generally faster than QEMU emulation. Unless there's a specific compatibility issue requiring QEMU, consider keeping the vz VM type for better performance. Note that vz may require macOS 13 or later, so this change should be coordinated with the macOS image update.
| colima start --vm-type qemu --memory 8 | |
| echo "DOCKER_HOST=unix://${HOME}/.colima/docker.sock" >> $GITHUB_ENV | |
| mkdir -p ~/.docker/cli-plugins | |
| ln -sfn /usr/local/bin/docker-compose ~/.docker/cli-plugins/docker-compose | |
| colima start --vm-type vz --memory 8 | |
| echo "DOCKER_HOST=unix://${HOME}/.colima/docker.sock" >> $GITHUB_ENV | |
| mkdir -p ~/.docker/cli-plugins | |
| ln-sfn /usr/local/bin/docker-compose ~/.docker/cli-plugins/docker-compose |
No description provided.