Skip to content

hotfixing jax bug in modes.py#29

Closed
maho3 wants to merge 1 commit into
eelregit:masterfrom
maho3:master
Closed

hotfixing jax bug in modes.py#29
maho3 wants to merge 1 commit into
eelregit:masterfrom
maho3:master

Conversation

@maho3
Copy link
Copy Markdown

@maho3 maho3 commented Apr 11, 2024

From #27 , the main branch of pmwd doesn't work due to a bug in linear_modes.

This just uses a hack to autodetermine the isrealobj from the modes, without need to manually specify.

Also, my autoformatter fixed some PEP things, but I can remove those changes if desired.

@eelregit
Copy link
Copy Markdown
Owner

Thanks Matt for the fix. And sorry for the delay. A fix without removing the feature controlled by the real flag has been merged in #32.
However, many interfaces would be changed once conf_refac branch is ready with the recently resumed development there #25.

@eelregit eelregit closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants