refactor: improve auth flow robustness and clean up vscode config#1121
Open
Wendong-Fan wants to merge 8 commits intomainfrom
Open
refactor: improve auth flow robustness and clean up vscode config#1121Wendong-Fan wants to merge 8 commits intomainfrom
Wendong-Fan wants to merge 8 commits intomainfrom
Conversation
1. SignUp.tsx handleReloadBtn: add null check for Stack app to prevent
runtime crash when VITE_STACK_* env vars are not configured
2. .vscode/tasks.json: untrack from git since .vscode/ is gitignored
and the referenced .debug.script.js was never created
3. Login.tsx handleLoginByStack: move setModelType('cloud') after token
validation to prevent inconsistent store state on auth failure
4. Login.tsx handleAuthCode: add missing await on handleLoginByStack
to prevent race condition with lock reset
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Wendong-Fan
force-pushed
the
fix/pr-1021-bugs
branch
from
b77bdd9 to
9ae0988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up improvements for #1021 (authentication and search history management):
handleReloadBtn, consistent with Login.tsx, to gracefully handle missing OAuth configurationsetModelType('cloud')after token validation inhandleLoginByStackto ensure store state consistencyawaitonhandleLoginByStack()inhandleAuthCodeto prevent race condition with lock reset.vscode/tasks.json: Remove from git tracking since.vscode/is gitignored and the referenced debug script no longer existsRelated