feat: add remember password function by bittoby · Pull Request #1317 · eigent-ai/eigent

bittoby · 2026-02-20T10:10:57Z

Related Issue

Description

Adds secure "Remember Me" credential storage for the login page using Electron's built-in safeStorage API, which encrypts credentials via OS-level keychain (macOS Keychain, Windows DPAPI, Linux Secret Service). No new dependencies required.

What it does:

Encrypts and persists email/password credentials locally at ~/.eigent/saved_credentials.enc (file permissions 0o600)
Auto-fills the most recently used account on login page load
Shows a saved accounts dropdown (with masked emails) when focusing the email field, allowing quick account switching
Each saved account can be individually removed from the dropdown
"Remember Me" checkbox controls whether credentials are saved or cleared after successful login

Files changed:

electron/main/index.ts — 3 IPC handlers (credentials-save, credentials-load, credentials-remove) using safeStorage.encryptString() / decryptString()
electron/preload/index.ts — Exposed credential APIs to renderer via electronAPI bridge
src/types/electron.d.ts — TypeScript declarations for new credential methods
src/pages/Login.tsx — Remember Me checkbox, saved accounts dropdown with outside-click dismiss, auto-fill on mount
11 i18n locale files — Added remember-me, saved-accounts, remove-account keys (en, zh-Hans, zh-Hant, ja, ko, de, fr, es, it, ru, ar)

Testing Evidence (REQUIRED)

login.mp4

I have included human-verified testing evidence in this PR.
This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
No frontend/UI changes in this PR.

What is the purpose of this pull request?

Bug fix
New Feature
Documentation update
Other

Contribution Guidelines Acknowledgement

I have read and agree to the Eigent Contribution Guideline

bittoby · 2026-02-20T10:47:24Z

@Pakchoioioi @Wendong-Fan Could you please review the PR?
thank you

Wendong-Fan · 2026-02-21T15:27:42Z

thanks @bittoby ! could @4pmtong and @fengju0213 help reviewing this feature?

…member-me-login

bittoby · 2026-02-25T20:44:34Z

@Wendong-Fan @4pmtong @fengju0213 I'd really appreciate your feedback!
thank you

nitpicker55555

This PR has several serious issues. A pure function is wrapped in useMemo even though it does not depend on any state and should be defined outside the component. Returning a function from useMemo with an empty dependency array is meaningless and looks like AI-driven over-optimization. The implementation stores plaintext passwords instead of persisting the existing auth token via setAuth, which indicates the current authentication flow was not properly reviewed. There is also a redundant map in credentials-load where the input and output shapes are identical, making it unnecessary code. In addition, credentialsLoad() has no error handling and lacks a catch on the promise.

Considering the extent of these problems, iterating through review cycles would likely cost more effort than rewriting it. I suggest closing this PR and submitting a clean one instead. @Wendong-Fan @4pmtong

bittoby · 2026-02-27T15:21:33Z

@nitpicker55555 please don't close this PR. I will update in this PR

…member-me-login

bittoby · 2026-02-27T16:10:41Z

@nitpicker55555 I updated to follow your feedback.

What i have changed:

Password storage removed - the implementation now persists the auth token (token, username, user_id) returned by the login API, not the user's password. Selecting a saved account calls setAuth directly and navigates without re-entering credentials.
useMemo misuse removed - maskEmail is now a plain module-level function outside the component.
Redundant .map() removed - credentials-load returns the accounts array directly.
Error handling added - credentialsLoad is now wrapped in try/catch.
Runtime bug fixed - the account filter was rejecting all saved entries because user_id from the API is a string at runtime, not a number. The filter now only validates email and token, which is sufficient.

fengju0213 · 2026-03-01T10:25:35Z

@nitpicker55555 I updated to follow your feedback.

What i have changed:

Password storage removed - the implementation now persists the auth token (token, username, user_id) returned by the login API, not the user's password. Selecting a saved account calls setAuth directly and navigates without re-entering credentials.

useMemo misuse removed - maskEmail is now a plain module-level function outside the component.

Redundant .map() removed - credentials-load returns the accounts array directly.

Error handling added - credentialsLoad is now wrapped in try/catch.

Runtime bug fixed - the account filter was rejecting all saved entries because user_id from the API is a string at runtime, not a number. The filter now only validates email and token, which is sufficient.

thanks @bittoby will review it asap

fengju0213

thanks @bittoby overall its good，I'm wondering if automatic autofill is sufficient, and automatic login isn't necessary, because there might be other operations on this login page later, such as changing the password, etc.
cc @Pakchoioioi

bytecii · 2026-03-04T00:04:40Z

electron/main/index.ts

+      user_id: number
+    ) => {
+      try {
+        const accounts = readSavedAccounts();


Should we change readSavedAccounts, writeSavedAccounts etc to async? such as fs.promises so that we do not block the ipc main thread

bytecii · 2026-03-04T00:16:34Z

src/pages/Login.tsx

+      email: account.email,
+      user_id: account.user_id,
+    });
+    setModelType('cloud');


Let's add a todo that we should need to avoid set this as cloud by default in the future

bytecii · 2026-03-04T00:17:28Z

src/pages/Login.tsx

+                          onClick={() => handleSelectAccount(account)}
+                        >
+                          <span className="text-label-md text-text-primary">
+                            {maskEmail(account.email)}


Do we need to mask in this way? maybe we should remove the masking

bytecii · 2026-03-04T00:36:37Z

src/pages/Login.tsx

+                    state={errors.email ? 'error' : undefined}
+                    note={errors.email}
+                    onEnter={handleLogin}
+                    onFocus={() => {


Now there is a problem that for example if we save an email such as abc@gmail.com
then in the email if I typed new one such as def@gmail.com the dropdown including the abc@gmail.com is still available.
We should have that if the prefix does not match with any saved emails then we should not show the dropdown

bittoby · 2026-03-04T00:41:38Z

Thanks for your feedback @bytecii . I will check again

bittoby · 2026-03-04T01:15:39Z

@bytecii I have updated all to follow your feedback. please review again.
thank you

feat: add remember password function

623edae

bittoby marked this pull request as draft February 20, 2026 10:11

bittoby marked this pull request as ready for review February 20, 2026 10:45

Wendong-Fan requested review from 4pmtong and fengju0213 February 21, 2026 15:25

Wendong-Fan added the Review Required label Feb 21, 2026

Wendong-Fan assigned bittoby Feb 21, 2026

Wendong-Fan added this to the Sprint 16 milestone Feb 21, 2026

bittoby added 2 commits February 22, 2026 12:07

Merge branch 'main' of https://github.com/bittoby/eigent into feat/re…

1b6b323

…member-me-login

fix: resolve merge conflict

98ede4a

nitpicker55555 requested changes Feb 27, 2026

View reviewed changes

bittoby added 2 commits February 27, 2026 15:28

Merge branch 'main' of https://github.com/bittoby/eigent into feat/re…

4dfada7

…member-me-login

fix: persist auth token instead of password for remember-me login

105a835

fix:revert env file

dbc687c

bittoby marked this pull request as draft February 27, 2026 16:30

chore: restore CSS class ordering to match main branch

15a46df

bittoby marked this pull request as ready for review February 27, 2026 16:42

bittoby requested a review from nitpicker55555 February 27, 2026 16:43

fengju0213 reviewed Mar 2, 2026

View reviewed changes

fix: solve merege conflict

4336b3b

bittoby force-pushed the feat/remember-me-login branch from 2ca5bc1 to 4336b3b Compare March 3, 2026 15:31

fix: remove unnecessary chagnes

36886ec

bytecii reviewed Mar 4, 2026

View reviewed changes

refactor: async credential I/O, dropdown filtering, remove email masking

58a594a

Conversation

bittoby commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issue

Description

Testing Evidence (REQUIRED)

What is the purpose of this pull request?

Contribution Guidelines Acknowledgement

Uh oh!

bittoby commented Feb 20, 2026

Uh oh!

Wendong-Fan commented Feb 21, 2026

Uh oh!

bittoby commented Feb 25, 2026

Uh oh!

nitpicker55555 left a comment

Choose a reason for hiding this comment

Uh oh!

bittoby commented Feb 27, 2026

Uh oh!

bittoby commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fengju0213 commented Mar 1, 2026

Uh oh!

fengju0213 left a comment

Choose a reason for hiding this comment

Uh oh!

bytecii Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

bytecii Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

bytecii Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

bytecii Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

bittoby commented Mar 4, 2026

Uh oh!

bittoby commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bittoby commented Feb 20, 2026 •

edited

Loading

bittoby commented Feb 27, 2026 •

edited

Loading