Skip to content

[FEAT] Move privacy consent to login and signup flow#946

Closed
sashimikun wants to merge 6 commits intoeigent-ai:mainfrom
sashimikun:feature/privacy-consent-login-2366781172810221309
Closed

[FEAT] Move privacy consent to login and signup flow#946
sashimikun wants to merge 6 commits intoeigent-ai:mainfrom
sashimikun:feature/privacy-consent-login-2366781172810221309

Conversation

@sashimikun
Copy link
Contributor

###Address:
#934

Description

This PR moves the privacy consent (Terms of Use and Privacy Policy acceptance) from the chat interface to the authentication flow. This ensures users explicitly agree to the terms before accessing the application, streamlining the chat experience and aligning with standard practices.

Changes include:

  • Added a required privacy consent checkbox to Login.tsx and SignUp.tsx, positioned above the submit button.
  • Updated handleLogin, handleRegister, and handleLoginByStack to validate the checkbox and update privacy settings via API upon success.
  • Removed the privacy consent banner and related blocking logic from ChatBox/index.tsx and InputBox.tsx.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Screenshot

image

@4pmtong
Copy link
Collaborator

4pmtong commented Jan 19, 2026

Thanks @sashimikun for the contribution!
@Pakchoioioi @Douglasymlai Any UI style adjustments needed?

@Douglasymlai
Copy link
Contributor

@sashimikun Thanks for your contribution. I have spotted some design token and components usage could be improved. I will create a PR on top of your current branch for UI improvement.

  • input > checkbox
  • checkbox color > information
  • text size token & border color token

@Douglasymlai
Copy link
Contributor

@sashimikun PR opened sashimikun#9

@Douglasymlai
Copy link
Contributor

@4pmtong This PR is good to be merged.

Copy link
Contributor

@Douglasymlai Douglasymlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @sashimikun . Everything looks good.

Copy link
Collaborator

@fengju0213 fengju0213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sashimikun great work! left some comment below cc @Douglasymlai

Reinstate privacy consent gating before sending

File: src/components/ChatBox/index.tsx
Lines: 134–143

The consent check was removed from handleSend, and ChatBox no longer fetches
/api/user/privacy.

Users can still revoke privacy permissions in Settings (/setting/privacy),
so after this change they are able to send messages or upload content even after
revoking consent.

This is a behavior regression from the previous “block on any false privacy flag” behavior.

Either:

  • restore client-side privacy consent gating (or enforce consent elsewhere), or
  • remove or lock the ability to revoke privacy permissions if consent is truly
    required before use.

@Douglasymlai
Copy link
Contributor

thanks @sashimikun great work! left some comment below cc @Douglasymlai

Reinstate privacy consent gating before sending

File: src/components/ChatBox/index.tsx Lines: 134–143

The consent check was removed from handleSend, and ChatBox no longer fetches /api/user/privacy.

Users can still revoke privacy permissions in Settings (/setting/privacy), so after this change they are able to send messages or upload content even after revoking consent.

This is a behavior regression from the previous “block on any false privacy flag” behavior.

Either:

  • restore client-side privacy consent gating (or enforce consent elsewhere), or
  • remove or lock the ability to revoke privacy permissions if consent is truly
    required before use.

From design side, either of those options work. Just need to add followup feedback notification, so there is no action block the user.
The only problem is @Pakchoioioi , is there any data privacy legal regulation that requires us to provide privacy setting options in side the app for user to turn on and off. If not we can just do what claude did.

  • Displaying our privacy and data policy
  • Provide option for user to export and not share their data with us. But as for collection and permission that's always allowed.
Screenshot 2026-01-22 at 11 59 53

@Pakchoioioi
Copy link
Contributor

Pakchoioioi commented Jan 22, 2026

Agreed with @Douglasymlai suggestion.

Regarding the specific implementation details:

  1. Data Export: We don't need a complex "Export Data" feature right now. Since we are focusing on local storage, a button to simply "Open Local File Path" would suffice. However, this is low priority and can be addressed in a future PR.
  2. Privacy Settings (The Solution):
    To resolve the regression issue mentioned by @fengju0213, let's restructure the Settings page:
    • Mandatory Consent: The checkbox at Login/Signup covers the basic Terms of Use. This cannot be revoked inside the app as it's required for the service.
    • Optional Consent: In /setting/privacy, please replace the current toggle with a "Help Improve Eigent" option.
      • ON: Grants us permission to analyze error logs and messages for improvement when user is using cloud version.
      • OFF: Eigent will not collect or analyze this data.

This way, turning off the setting won't block the user from using the chat features, it only stops data collection for improvements.

Screenshot 2026-01-22 at 22 18 51 Screenshot 2026-01-22 at 22 23 49

@Pakchoioioi Pakchoioioi added this to the Sprint 12 milestone Jan 26, 2026
@4pmtong
Copy link
Collaborator

4pmtong commented Feb 2, 2026

Thanks @sashimikun, thank you so much for this contribution!
left some comment below cc @Douglasymlai
we also need to add privacy consent to our official website's login/registration flow.

@eureka928
Copy link
Contributor

I have branch ready as this is stale for a while... I'd like to open that PR, lmk

@a7m-1st
Copy link
Collaborator

a7m-1st commented Feb 24, 2026

Apologies for the delay in final decision but this PR is updated in #1239.
Thanks for your work @sashimikun & thx for reviews @Douglasymlai @fengju0213 @Pakchoioioi @4pmtong

@a7m-1st a7m-1st closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Move privacy consent to login/registration flow

8 participants