[FEAT] Move privacy consent to login and signup flow#946
[FEAT] Move privacy consent to login and signup flow#946sashimikun wants to merge 6 commits intoeigent-ai:mainfrom
Conversation
|
Thanks @sashimikun for the contribution! |
|
@sashimikun Thanks for your contribution. I have spotted some design token and components usage could be improved. I will create a PR on top of your current branch for UI improvement.
|
|
@sashimikun PR opened sashimikun#9 |
…66781172810221309-token-alignment
|
@4pmtong This PR is good to be merged. |
Douglasymlai
left a comment
There was a problem hiding this comment.
Thanks for your contribution @sashimikun . Everything looks good.
fengju0213
left a comment
There was a problem hiding this comment.
thanks @sashimikun great work! left some comment below cc @Douglasymlai
Reinstate privacy consent gating before sending
File: src/components/ChatBox/index.tsx
Lines: 134–143
The consent check was removed from handleSend, and ChatBox no longer fetches
/api/user/privacy.
Users can still revoke privacy permissions in Settings (/setting/privacy),
so after this change they are able to send messages or upload content even after
revoking consent.
This is a behavior regression from the previous “block on any false privacy flag” behavior.
Either:
- restore client-side privacy consent gating (or enforce consent elsewhere), or
- remove or lock the ability to revoke privacy permissions if consent is truly
required before use.
From design side, either of those options work. Just need to add followup feedback notification, so there is no action block the user.
|
|
Agreed with @Douglasymlai suggestion. Regarding the specific implementation details:
This way, turning off the setting won't block the user from using the chat features, it only stops data collection for improvements.
|
|
Thanks @sashimikun, thank you so much for this contribution! |
|
I have branch ready as this is stale for a while... I'd like to open that PR, lmk |
|
Apologies for the delay in final decision but this PR is updated in #1239. |



###Address:
#934
Description
This PR moves the privacy consent (Terms of Use and Privacy Policy acceptance) from the chat interface to the authentication flow. This ensures users explicitly agree to the terms before accessing the application, streamlining the chat experience and aligning with standard practices.
Changes include:
Login.tsxandSignUp.tsx, positioned above the submit button.handleLogin,handleRegister, andhandleLoginByStackto validate the checkbox and update privacy settings via API upon success.ChatBox/index.tsxandInputBox.tsx.What is the purpose of this pull request?
Screenshot