[EuiFlyoutMenu] add hideTitle prop for “main” flyouts in a session #9150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tim Sullivan <[email protected]> Co-authored-by: Timothy Sullivan <[email protected]> Co-authored-by: Weronika Olejniczak <[email protected]>
…ions in top menu (elastic#8997) Co-authored-by: Tomasz Kajtoch <[email protected]>
…ransition animations of managed flyouts (elastic#9015) Co-authored-by: Arturo Castillo Delgado <[email protected]> Co-authored-by: Tim Sullivan <[email protected]>
Co-authored-by: Clint Andrew Hall <[email protected]> Co-authored-by: Weronika Olejniczak <[email protected]> Co-authored-by: Tomasz Kajtoch <[email protected]>
… use for child flyouts only (elastic#9056) Co-authored-by: Tim Sullivan <[email protected]>
Co-authored-by: Timothy Sullivan <[email protected]> Co-authored-by: Tim Sullivan <[email protected]>
Co-authored-by: Timothy Sullivan <[email protected]> Co-authored-by: Tim Sullivan <[email protected]>
…rom interacting with the Flyout System (elastic#9124) Co-authored-by: Timothy Sullivan <[email protected]>
tsullivan
force-pushed
the
feat/flyout-system
branch
from
3934a1f to
d199818
Compare
tsullivan
force-pushed
the
feat/flyout-system
branch
from
d199818 to
32edff0
Compare
tsullivan
force-pushed
the
flyout-system/fix-main-header-design
branch
2 times, most recently
from
68c5edd to
1a14cd0
Compare
tsullivan
force-pushed
the
flyout-system/fix-main-header-design
branch
from
1a14cd0 to
867d6ba
Compare
tsullivan
commented
Oct 28, 2025
| // TODO: allow aria-labelledby references to be used | ||
| let title = _flyoutMenuProps?.title || props['aria-label']; | ||
| if (level === LEVEL_MAIN && !title) { | ||
| console.warn( |
Member
Author
There was a problem hiding this comment.
Maybe we want this message shown only in development environments, if that is an option.
tsullivan
commented
Oct 28, 2025
| ); | ||
|
|
||
| // Set title from flyoutMenuProps or aria-label | ||
| // TODO: allow aria-labelledby references to be used |
Member
Author
There was a problem hiding this comment.
Working this TODO is not part of this PR. There's a possibility the element with the id will not be rendered initially, which means we need to have a DOM mutation observer on the flyout content and a new action in the flyout manager reducer to update the title at arbitrary times.
tsullivan
commented
Oct 28, 2025
| The "main" flyout in a session should use `EuiFlyoutHeader` for the actual | ||
| flyout heading. For this reason, the `title` given from `flyoutMenuProps` will | ||
| not be visible to end users. However, a title is still needed for the history | ||
| navigation feature of the flyout session management system. |
Member
Author
There was a problem hiding this comment.
Should this mention that the menu of a child flyout does show the title given from flyoutMenuProps? Or is that already implied well enough?
Member
Author
There was a problem hiding this comment.
Maybe this:
:::info Note
The `title` from `flyoutMenuProps` is hidden from the menu on main flyouts (which should use
`EuiFlyoutHeader` for the visible heading) but is displayed in the menu of child flyouts.
For main flyouts, the title is primarily used for history navigation.
18 tasks
Collaborator
💚 Build SucceededHistory
cc @tkajtoch |
Collaborator
💚 Build Succeeded
History
cc @tkajtoch |
Member
Author
|
Blocked on #9178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #9148
EuiFlyoutMenuPropshideTitleprop.The default is
truefor "main" system flyouts,falsefor everything elseWhy are we making this change?
This fixes an issue with the initial Flyout System implementation, where "main" flyouts have a title in the menu bar, which is wrong:
EuiFlyoutHeaderis not deprecated and the "main" flyout UI should use it for a heading.On the other hand, "child" flyouts are a new concept and these types of flyouts are designed to have their title text shown in the top menu bar. This makes sense because "main" and "child" flyouts serve different purposes, and their menu bars should also serve different purposes - the main menu bar shows the history controls and not a title; the child menu bar shows the title and not the history controls.
Screenshots #
Impact to users
Before this fix, it was assumed that flyout designs would change from using an
EuiFlyoutHeaderinto a design where the title is in the menu bar - even for "main" system flyouts. Since that assumption was wrong, this fix means there will be an easier migration path from non-managed flyouts into managed flyouts.QA
Remove or strikethrough items that do not apply to your PR.
General checklist
[ ] Checked in both light and dark modes[ ] Checked in mobile@defaultif default values are missing) and playground toggles[ ] Updated visual regression tests[ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)[ ] If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)[ ] If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)