Skip to content

Conversation

@acstll
Copy link
Contributor

@acstll acstll commented Nov 6, 2025

Summary

Important

This PR merges into a feature branch

This adds time zone information to the date picker popovers in the EuiSuperDatePicker. Passing the name of the time zone is required. The space where the time zone information is shown can be customized with a render function prop.

Resolves 🔒 https://github.com/elastic/eui-private/issues/440

Why are we making this change?

As part of a series of improvements to EuiSuperDatePicker that should have a positive immediate impact for users.

Screenshots

Figma

Screenshot 2025-11-07 at 13 11 29

Impact to users

🟢 No impact. Setting the timeZoneDisplay prop is needed in order for the info to show. No logic in the component is affected.

QA

📘 I'm open to feedback regarding:

  • the prop names
  • whether the render function (timeZoneCustomDisplayRender) is the best approach for the custom content
    • the requirement, as in the acceptance criteria is: "Optionally add an icon button that links to the settings page where the time zone can be changed"
  • anything else is needed for accessibility — I considered nothing specific was needed

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
    • If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@acstll acstll self-assigned this Nov 6, 2025
@acstll acstll marked this pull request as ready for review November 7, 2025 12:26
@acstll acstll requested a review from a team as a code owner November 7, 2025 12:26
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @acstll

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @acstll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants