[EuiSuperDatePicker] More forgiving absolute input #9199
+38
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💭 I'd suggest to run all changes in the feature branch against Kibana CI before merging to main. That way we'll know early if there are any unexpected issues. |
mgadewoll
approved these changes
Nov 12, 2025
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
🟢 The changes work as expected. That's a pretty neat user improvement 🎉
Contributor
Author
that sounds like a good idea, will do 👍 |
acstll
force-pushed
the
feat/super-date-picker-track-1-ms-1
branch
from
9b13608 to
e0802ae
Compare
acstll
changed the base branch from
feat/super-date-picker-track-1-ms-1
to
main
acstll
force-pushed
the
super-date-picker-forgiving-input
branch
from
36c3715 to
dd67df6
Compare
This reverts commit cf0a055. Wrongly included here because of a rebase
acstll
force-pushed
the
super-date-picker-forgiving-input
branch
from
b133434 to
f469a97
Compare
Collaborator
💔 Build Failed
Failed CI StepsHistory
cc @acstll |
Collaborator
💔 Build Failed
Failed CI StepsHistory
cc @acstll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
This PR merges into a feature branch
This makes the manual input of date and times more forgiving, in the Absolute tab. Meaning that is not needed for users to enter the entire date (sometimes in the in the exact format) for it to be parsed correctly.
Resolves https://github.com/elastic/eui-private/issues/439 🔒
Why are we making this change?
As part of a series of improvements to
EuiSuperDatePickerthat should have a positive immediate impact for users.Impact to users
🟡 Low to no impact. No changes required. I think it's unlikely but some tests may fail.
Changes
Technically this is changing a single prop passed to the underlying library doing the date/time parsing, Moment.js. Namely the prop for enabling Strict Mode parsing.
Until now strict mode was enabled for all formats: the one passed in the
dateFormatprop, and the other 3 supported (ISO 8601, RFC 2822 and Unix timestamp in seconds)). With this change, it will be disabled for the passeddateFormatonly if the entered value is not any of the other 3 formats.Parsing for ISO 8601, RFC 2822 and Unix remains unchanged. It behaves like the following:
ISO 8601 (unchanged)
Example:
2025-11-10T11:07:02ZForgiving. Entering a partial value works e.g.
2025-11.RFC 2822 (unchanged)
Example:
Tue, 10 Nov 2025 11:07:00 +0000Partially forgiving, only the optional day of week e.g.
Tuecan be left out.Unix timestamp, in seconds (unchanged)
Example:
1762772820Not forgiving (for obvious reasons).
Examples of changes in parsing
When entering a value and pressing Enter.
Nov 10, 2025Nov 10 2025Nov 10NovNov 10 2025 12:342024✝︎ parsed as ISO 8601
QA
🔗 Storybook for manual testing
General checklist
Checked in both light and dark modesChecked in both MacOS and Windows high contrast modes(emulate forced colors if you do not have access to a Windows machine.)Checked in mobileChecked for accessibility including keyboard-only and screenreader modesAdded documentationProps have proper autodocs (using@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesUpdated visual regression testsIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)