Skip to content

Conversation

@tkajtoch
Copy link
Member

@tkajtoch tkajtoch commented Nov 14, 2025

Summary

Part of https://github.com/elastic/eui-private/issues/448; the working implementation lives in https://github.com/elastic/eui/tree/build/gh-release-action and will be split into manageable PR chunks

This PR updates the created release.yml workflow to add jobs that run unit and e2e tests, and removes the obsolete preinstall echo script from our root package.json.

The added inputs will be used in jobs added in follow-up PRs to make reviewing easier.

Why are we making this change?

Part of https://github.com/elastic/eui-private/issues/448

Impact to users

Infrastructure only change. No impact to users.

QA

The changes can really only be tested after merging this PR to main due to the added release_ref input, which is currently invisible by GitHub - it only sees the workflow version available on main.

  • Verify that the executed commands and YML structure look correct

@tkajtoch tkajtoch self-assigned this Nov 14, 2025
@tkajtoch tkajtoch requested a review from a team as a code owner November 14, 2025 10:29
@tkajtoch tkajtoch added skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) infrastructure labels Nov 14, 2025
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @tkajtoch

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @tkajtoch

# - name: Lint
# run: yarn workspaces foreach --all --parallel --topological-dev --exclude @elastic/eui-website --exclude @elastic/eui-monorepo --exclude @elastic/eui-docgen run lint
- name: Unit tests
run: yarn workspaces foreach --all --parallel --topological-dev --exclude @elastic/eui-website --exclude @elastic/eui-monorepo --exclude @elastic/eui-docgen run test-unit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so pretty... 🥹

Copy link
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Looks good 👍🏻 I have a doubt but it's not something that could likely break

@tkajtoch tkajtoch merged commit 3e6528a into elastic:main Nov 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants