Skip to content

Conversation

@andreineculau
Copy link
Collaborator

@andreineculau andreineculau commented Feb 24, 2025

compare dirty before and after. see #195 (comment)

PS: switched to the same dirty check we have in run_safety_checks for consistency

@andreineculau andreineculau requested a review from jmurty February 24, 2025 21:12
@jmurty
Copy link
Collaborator

jmurty commented Mar 3, 2025

This looks like a good improvement thanks, but I'm getting test failures in cases where a newly-created repository doesn't yet have a HEAD reference:

fatal: bad revision 'HEAD'

We will need to find a variant of the dirty files check command that works in this scenario.

Note that I moved the duplicated dirty file check command into a reusable function list_dirty_files() so it only needs to be adjusted in one place.

@andreineculau andreineculau force-pushed the andreineculau-patch-4 branch from 8b5acc2 to 49b346a Compare March 15, 2025 06:33
@jmurty jmurty merged commit 48b801d into main Mar 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants