Internal: Expose custom media queries#659
Open
rami-elementor wants to merge 3 commits into
Open
Conversation
Add custom media queries for responsive design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add custom media queries for responsive design.
This PR only adds
@custom-mediato the CSS. At this point they are not used inside@mediaas it's not fully browser-compatible. But the PR adds them, to expose the breakpoints for external users.Result:
The naming convention and best practices are based on Open Props
https://github.com/argyleink/open-props/blob/main/src/props.media.css
✨ PR Description
1. Problem & Context
Exposing custom CSS media queries as reusable variables to decouple breakpoint definitions from individual media query usages, reducing maintenance burden.
2. What Changed (Where)
dev/scss/theme/_layout.scss: Added 8 custom media query definitions for xs/sm/md/xl breakpoints (min/max variants).3. How It Works
Custom media queries map named aliases (
--hello-screen-xs-min, etc.) to computed breakpoint expressions. Consumers can then use@media (--hello-screen-xs-min)instead of repeating the calculation, centralizing breakpoint logic.4. Risks
None identified. Additive change with no breaking modifications to existing media queries or container logic.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how