Skip to content

Conversation

@jo-elimu
Copy link
Member

https://github.com/elimu-ai/model/releases/tag/model-2.0.127

Issue Number

  • Resolves #

Purpose

Technical Details

Testing Instructions

Screenshots


Format Checks

Note

Files in PRs are automatically checked for format violations with mvn spotless:check.

If this PR contains files with format violations, run mvn spotless:apply to fix them.

@jo-elimu jo-elimu self-assigned this Sep 20, 2025
@jo-elimu jo-elimu requested a review from a team as a code owner September 20, 2025 14:52
@jo-elimu jo-elimu requested review from AshishBagdane, SnehaHS65 and Souvik-Cyclic and removed request for a team September 20, 2025 14:52
@codecov
Copy link

codecov bot commented Sep 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.84%. Comparing base (f79d856) to head (450e30d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2349   +/-   ##
=========================================
  Coverage     16.84%   16.84%           
  Complexity      465      465           
=========================================
  Files           264      264           
  Lines          7848     7848           
  Branches        903      903           
=========================================
  Hits           1322     1322           
  Misses         6450     6450           
  Partials         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Do the extraction for all languages.
@jo-elimu jo-elimu merged commit a5078b8 into main Sep 20, 2025
13 of 14 checks passed
@jo-elimu jo-elimu deleted the model-2.0.127 branch September 20, 2025 15:13
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Removes language-specific conditions in two JSPs to always render per-character display when word.text is present. Updates comments accordingly. Updates pom-dependency-tree.txt to bump top-level artifact versions while keeping transitive structure unchanged.

Changes

Cohort / File(s) Change Summary
Dependency metadata
pom-dependency-tree.txt
Updated artifact versions: ai.elimu:webapp:war 2.6.140-SNAPSHOT → 2.6.142-SNAPSHOT; ai.elimu:model:jar model-2.0.124 → model-2.0.127. No structural changes to dependency tree.
Word JSP views
src/main/webapp/WEB-INF/jsp/content/word/create.jsp, src/main/webapp/WEB-INF/jsp/content/word/edit.jsp
Removed language checks (HIN/THA) around per-letter rendering. Now always splits word.text into characters and displays them (when not empty). Updated inline comments; output structure unchanged apart from condition removal.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Controller
  participant View as create.jsp / edit.jsp

  User->>Controller: Request Word create/edit page
  Controller-->>View: Forward with word.text
  alt word.text is empty
    View-->>User: Render page (no per-letter display)
  else word.text not empty
    Note over View: New behavior: render letters for all languages
    loop For each character in word.text
      View-->>User: Output character + space
    end
  end
Loading
sequenceDiagram
  %% Comparison of old vs new gating
  participant Old as Old JSP
  participant New as New JSP

  alt Old: word.text not empty AND language in {HIN, THA}
    Old-->>Old: Render per-letter
  else Old: condition not met
    Old-->>Old: Skip per-letter
  end

  alt New: word.text not empty
    New-->>New: Render per-letter
  else
    New-->>New: Skip per-letter
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch model-2.0.127

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e8fdc8 and 450e30d.

⛔ Files ignored due to path filters (1)
  • pom.xml is excluded by !**/*.xml
📒 Files selected for processing (3)
  • pom-dependency-tree.txt (1 hunks)
  • src/main/webapp/WEB-INF/jsp/content/word/create.jsp (1 hunks)
  • src/main/webapp/WEB-INF/jsp/content/word/edit.jsp (1 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants