-
-
Notifications
You must be signed in to change notification settings - Fork 70
chore(deps): model 2.0.127 #2349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
=========================================
Coverage 16.84% 16.84%
Complexity 465 465
=========================================
Files 264 264
Lines 7848 7848
Branches 903 903
=========================================
Hits 1322 1322
Misses 6450 6450
Partials 76 76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Do the extraction for all languages.
|
Caution Review failedThe pull request is closed. WalkthroughRemoves language-specific conditions in two JSPs to always render per-character display when word.text is present. Updates comments accordingly. Updates pom-dependency-tree.txt to bump top-level artifact versions while keeping transitive structure unchanged. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Controller
participant View as create.jsp / edit.jsp
User->>Controller: Request Word create/edit page
Controller-->>View: Forward with word.text
alt word.text is empty
View-->>User: Render page (no per-letter display)
else word.text not empty
Note over View: New behavior: render letters for all languages
loop For each character in word.text
View-->>User: Output character + space
end
end
sequenceDiagram
%% Comparison of old vs new gating
participant Old as Old JSP
participant New as New JSP
alt Old: word.text not empty AND language in {HIN, THA}
Old-->>Old: Render per-letter
else Old: condition not met
Old-->>Old: Skip per-letter
end
alt New: word.text not empty
New-->>New: Render per-letter
else
New-->>New: Skip per-letter
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
https://github.com/elimu-ai/model/releases/tag/model-2.0.127
Issue Number
Purpose
Technical Details
Testing Instructions
Screenshots
Format Checks
Note
Files in PRs are automatically checked for format violations with
mvn spotless:check.If this PR contains files with format violations, run
mvn spotless:applyto fix them.