lsp-mode: Use cl-loop to stop allocating lambdas during hot file loops #4935
+34
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
approved these changes
Dec 12, 2025
Member
|
LGTM. Thank you! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a large project with a ton of files, when I changed between branches that had a lot of changed files,
lsp--file-process-eventwould freeze my editor for one full minute due to CPU and memory being pegged—I saw GC using 60% of CPU and thestring-matchinside that function using 40% of CPU.After rewriting this function to avoid allocating the intermediate lambdas, the time my editor is spent frozen is now reduced to about two seconds.
I also updated
lsp--send-will-rename-files-pto be rewritten in the same way given that it had a very similar-any?structure.