-
Notifications
You must be signed in to change notification settings - Fork 529
Add compute missing parameter in get_model_meta #3801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add compute missing parameter in get_model_meta #3801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a compute_missing parameter to the get_model_meta function to allow computing missing model metadata attributes (number of parameters and memory usage) from the HuggingFace Hub when they are not available in the model registry.
Key Changes:
- Added
compute_missingparameter toget_model_metafunction signature with a default value ofFalse - Added logic to compute missing
n_parametersandmemory_usage_mbattributes when requested - Updated function documentation to describe the new parameter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Samoed How the typechecking tests suddenly failing in all PRs?
|
|
It was added to main. It's not failing in all prs, but if there is an error it will fail. Currently, the reason is that you call method that not existing. I fixed it |
|
@Samoed Do we have to add tests for this, or is it good? |
|
Yes, it's better to add a test |
|
@KennethEnevoldsen Just tagging you to review this one whenever you get time |
closes #3693