Skip to content

Conversation

@ayush1298
Copy link
Collaborator

closes #3693

Copilot AI review requested due to automatic review settings December 27, 2025 17:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a compute_missing parameter to the get_model_meta function to allow computing missing model metadata attributes (number of parameters and memory usage) from the HuggingFace Hub when they are not available in the model registry.

Key Changes:

  • Added compute_missing parameter to get_model_meta function signature with a default value of False
  • Added logic to compute missing n_parameters and memory_usage_mb attributes when requested
  • Updated function documentation to describe the new parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ayush1298
Copy link
Collaborator Author

@Samoed How the typechecking tests suddenly failing in all PRs?
getting this error:

mteb/models/get_model_meta.py:133: error: "type[ModelMeta]" has no attribute "from_hf" [attr-defined]

@Samoed
Copy link
Member

Samoed commented Dec 29, 2025

It was added to main. It's not failing in all prs, but if there is an error it will fail. Currently, the reason is that you call method that not existing. I fixed it

@ayush1298
Copy link
Collaborator Author

@Samoed Do we have to add tests for this, or is it good?

@Samoed
Copy link
Member

Samoed commented Dec 30, 2025

Yes, it's better to add a test

@ayush1298
Copy link
Collaborator Author

ayush1298 commented Jan 5, 2026

@KennethEnevoldsen Just tagging you to review this one whenever you get time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add compute_missing to mteb.get_model_meta

2 participants